Attention is currently required from: Timur Davydov, fixeria, laforge. Hoernchen has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: transceiver: add optional WebSDR device support ...................................................................... Patch Set 11: Code-Review-2 (1 comment) Patchset: PS11: I don't mind refactoring but cluttering everything with ifdefs is not acceptable, we won't be able to maintain code like that, because we neither run the web backend nor do existing users nor do we want to run it and we don't have tests either. That would mean code rot as soon as anyone changes anything because we don't know where and what to wrap in ifdefs. The only way I see here is to derive/template a WebTransceiver or something like that and just override parts, so this can be somehow contained. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 11 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Wed, 29 Apr 2026 18:10:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
