Attention is currently required from: Timur Davydov, pespin. Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: transceiver: add optional WebSDR device support ...................................................................... Patch Set 10: (11 comments) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/695a8c4f_1cd43401?usp=email : PS10, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun, please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/7b7c5491_0ed461cb?usp=email : PS10, Line 247: TIMESTAMP ts, unsigned samples_skipped); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/c2f166d5_c9309b05?usp=email : PS10, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/fe7cc3d4_8c63c847?usp=email : PS10, Line 258: bool driveReceiveFIFO(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/b74a6f6d_10a78d66?usp=email : PS10, Line 264: @brief modulation and sorting of GSM bursts from GSM core please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/2010a7f5_f682f9dd?usp=email : PS10, Line 265: @param chan channel number please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/77e6c8d4_c3ec6ed5?usp=email : PS10, Line 266: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/326f3ef2_2a686015?usp=email : PS10, Line 267: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/00447d61_17d49de6?usp=email : PS10, Line 270: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line File Transceiver52M/radioInterface.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/1052ab8f_b86ae496?usp=email : PS10, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/9a83a74b_ab4f20ea?usp=email : PS10, Line 137: int fillPullBuffer(std::vector<short *> &bufs, size_t samples, int recvunderrun, TIMESTAMP ts); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 10 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Wed, 18 Mar 2026 15:54:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
