Attention is currently required from: Hoernchen, Timur Davydov, fixeria, 
laforge.

pespin has posted comments on this change by Timur Davydov. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )

Change subject: transceiver: add optional WebSDR device support
......................................................................


Patch Set 10:

(1 comment)

File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/21bae773_fa93288d?usp=email
 :
PS10, Line 1132:     msgLen = read(mDataSockets[chan], buffer, sizeof(buffer));
> In this work we are not planning to adapt or restructure the existing 
> threading model. […]
Yeah word it as you like, but removing all the threads and putting all of it in 
one thread sounds to me like changing the threading model in osmo-trx :)Let's 
wait to see your proposal to include that into osmo-trx, that alone deserves 
already a specific commit imho.



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d
Gerrit-Change-Number: 42411
Gerrit-PatchSet: 10
Gerrit-Owner: Timur Davydov <[email protected]>
Gerrit-Reviewer: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: Timur Davydov <[email protected]>
Gerrit-Comment-Date: Fri, 20 Mar 2026 12:04:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: Timur Davydov <[email protected]>

Reply via email to