Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email ) Change subject: transceiver: add optional WebSDR device support ...................................................................... Patch Set 10: (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/b6d098ab_252e13f8?usp=email : PS10, Line 1132: msgLen = read(mDataSockets[chan], buffer, sizeof(buffer)); > Could you please clarify if I understood you correctly? […] I don't have a 100% specific implementation at hand, since I'm still not seeing afacit how are you passing the buffers in the emscripten case. But my general point is yes, something like what you mention. I don't see why you forcibly need some intermediate buffers, I'd say the methods/APIs/classes can be adapted to be more modular to fullfill your requirements. That needs some more extra work that what you presented so far in order to be merged though, not just a bunch of ifdefs or some weird code paths/functions where you may either pull a buffer or pass it, etc. In summary, if you plan to exchange TRXC and TRXD with something else, then provide proper abstraction for it and present it. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 10 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Fri, 20 Mar 2026 08:35:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: Timur Davydov <[email protected]>
