On Sun, 21 Aug 2005 23:10:58 -0400 "Nathan L. Adams" <[EMAIL PROTECTED]> wrote: | What are the most common ebuild mistakes? | | A script will never be a substitute for good peer review, but it can | easily detect (and even correct in some cases) common syntax errors. | So I'm looking for a list of things like under-quoting variables, | improper spacing, etc.
KEYWORDS, under-quoting of variables (we didn't used to care about
quoting on ${D} etc), using einstall when it's not necessary, using
emake when make should be used, using make when emake should be used,
general formatting, missing ()s after use? tokens, duff header, duff
indenting, weird extra blank lines, not being sandbox-aware, not using
IUSE correctly, specifying USE flags and not using them, things being
detected based upon what's installed rather than USE flags, not using
eclasses when eclasses should be used. That lot should get you started,
I can come up with a whole load more once you've gotten those ones
nailed down :)
Existing tools will already get some of these. However, most
user-submitted ebuilds have quite clearly not been run through
repoman...
--
Ciaran McCreesh : Gentoo Developer (Vim, Shell tools, Fluxbox, Cron)
Mail : ciaranm at gentoo.org
Web : http://dev.gentoo.org/~ciaranm
pgpJHMkjJW5SY.pgp
Description: PGP signature
