maillog: 22/08/2005-04:25:38(+0100): Ciaran McCreesh types
> On Sun, 21 Aug 2005 23:10:58 -0400 "Nathan L. Adams" <[EMAIL PROTECTED]>
> wrote:
> | What are the most common ebuild mistakes?
> | ...
> 
> KEYWORDS, under-quoting of variables (we didn't used to care about
> quoting on ${D} etc), using einstall when it's not necessary, using
> emake when make should be used, using make when emake should be used,

When should make be used? I thought that ebuilds should always use
emake, and if necessary -- emake -j1. But never make.

> general formatting, missing ()s after use? tokens, duff header, duff
> indenting, weird extra blank lines, not being sandbox-aware, not using
> IUSE correctly, specifying USE flags and not using them, things being
> detected based upon what's installed rather than USE flags, not using
> eclasses when eclasses should be used. That lot should get you started,
> I can come up with a whole load more once you've gotten those ones
> nailed down :)
> 
> Existing tools will already get some of these. However, most
> user-submitted ebuilds have quite clearly not been run through
> repoman...

-- 
 >   Georgi Georgiev    > Good judgement comes from experience.         >
<     [EMAIL PROTECTED]    <  Experience comes from bad judgement. --      <
 >  +81(90)2877-8845    > Jim Horning                                   >

Attachment: pgpNkentC2beU.pgp
Description: PGP signature

Reply via email to