I've waited out on the vote intentionally to see what others hand.
The licensing issues that RAT turned up seem minor to me, especially
being in project files that are not part of a binary distribution and
probably not even needed for compilation of the codebase in general.
So...
+1 on this release
Erik
On Mar 28, 2007, at 9:55 PM, George Aroush wrote:
Thanks Robert! No, you don't have to feel bad about your +0 vote,
you did
your part.
All: Please review this release and give me your vote so I can move
this
release on. At least, let me know if what Robert found is (the one
file
that has old license header) is a release stopper so I can go back and
re-package the release for a new vote.
Regards,
-- George Aroush
-----Original Message-----
From: robert burrell donkin [mailto:[EMAIL PROTECTED]
Sent: Wednesday, March 28, 2007 5:22 PM
To: general@incubator.apache.org
Subject: Re: [VOTE] [Retry] Approve the release of Apache
Lucene.Net 2.0
build 004 incubating
On 3/28/07, George Aroush <[EMAIL PROTECTED]> wrote:
Hi Robert,
Thanks for taking your time and looking at this release. To answer
your
questions:
The files *.csproj, and *.sln are the Visual Studio.NET project files
-- those are auto generated and thus I can't edit them outside the
IDE
-- the same goes to the few *.cs files that you noticed as well as
the
few *.xml and *.html files that you highlighted.
yeh
IMHO it's pretty naffy that you can't add headers but that's life,
i suppose
- or at least m$
For the file,
https://svn.apache.org/repos/asf/incubator/lucene.net/trunk/C%23/
contr
ib/Sno wball.Net/Test/Analysis/Snowball/TestSnowball.cs where you
pointed out the use of the old style Apache License, it looks like
http://www.apache.org/legal/src-headers.html#faq-update-scripts
didn't
do the job well here. This is an original work -- will this issue
prevent a release?.
different people have different opinions :-/
(hopefully people will jump in here)
IMHO it's a judgment call. i wouldn't cut a release with any header
issues
of this kind but i wouldn't -1 one either.
RAT is good at catching this kind of issue (though it will pick up
a lot of
false negatives for the XML and HTML files)
Thanks for catching the grammatical error in the README.txt: "An
MADN ..."
I fixed it in the SVN release.
Again, thanks for taking your time and looking at this release
candidate.
Please let me know if I addressed all of your questions and if I get
your +1 or -1 vote.
+0 due to old license
(but i feel a little bad about it)
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
