> 1) I suggest that somebody with ECN smarts should glance at it (e.g. David > Black).
I found an ECN concern, and hence added the TSV ADs to the CC line. Section 3.2 says: The Congestion-Treatment AVP (AVP Code TBD) is of type Grouped and indicates how congested traffic, i.e., traffic that has Explicit Congestion Notification Congestion Experienced marking set or some other administratively defined criteria, is treated. That appears to say that the congestion treatment may be applied solely to packets that have the CE (Congestion Experienced) marking. That would be a problem, because the defined semantics of a CE marking is that it applies to the entire flow (e.g., causes TCP to react as if a packet has been dropped), hence the congestion treatment ought to apply to the entire flow. In other words, one wants to be able to use the ECN-IP-Codepoint AVP as part of the condition that determines whether the filter rule matches, but ignore that AVP (i.e., wildcard it) in determining what traffic the action applies to, so that the response to detecting a congested flow (i.e., packets with ECN field containing CE) applies to all packets in the flow, regardless of the value in the CE field. Otherwise, the result may be ineffective, as it won't encompass packets in the congested flow that aren't CE-marked. Am I reading the draft correctly? Thanks, --David > -----Original Message----- > From: Gen-art [mailto:gen-art-boun...@ietf.org] On Behalf Of Brian E Carpenter > Sent: Friday, June 05, 2015 12:16 AM > To: draft-ietf-dime-congestion-flow-attributes....@ietf.org; General Area > Review Team > Subject: [Gen-art] Gen-ART telechat review of draft-ietf-dime-congestion-flow- > attributes-01 > > Nothing to add to my earlier review (i.e. Ready with comments). > > Brian > > -------- Forwarded Message -------- > Subject: RE: Gen-ART Last Call review of draft-ietf-dime-congestion-flow- > attributes-01 > Date: Thu, 4 Jun 2015 16:57:49 +0000 > From: Black, David <david.bl...@emc.com> > To: Kathleen Moriarty <kathleen.moriarty.i...@gmail.com>, Brian E Carpenter > <brian.e.carpen...@gmail.com>, > <lionel.mor...@orange.com> <lionel.mor...@orange.com> > CC: draft-ietf-dime-congestion-flow-attributes....@ietf.org <draft-ietf-dime- > congestion-flow-attributes....@ietf.org>, General > Area Review Team <gen-art@ietf.org>, Black, David <david.bl...@emc.com> > > > 1) I suggest that somebody with ECN smarts should glance at it (e.g. David > Black). > > Last Call on this draft happened while I was on vacation; I’ll try to take a > look early next week before the telechat. > > Thanks, > --David > > From: Kathleen Moriarty [mailto:kathleen.moriarty.i...@gmail.com] > Sent: Thursday, June 04, 2015 11:41 AM > To: Brian E Carpenter; <lionel.mor...@orange.com> > Cc: draft-ietf-dime-congestion-flow-attributes....@ietf.org; General Area > Review Team; Black, David > Subject: Re: Gen-ART Last Call review of draft-ietf-dime-congestion-flow- > attributes-01 > > Brian, > > Thank you for your review. I agree, the shepherd report should be amended to > remove the 'updates' language since the extensions > are optional. > > Thank you, > Kathleen > > On Sun, May 24, 2015 at 11:59 PM, Brian E Carpenter > <brian.e.carpen...@gmail.com<mailto:brian.e.carpen...@gmail.com>> wrote: > I am the assigned Gen-ART reviewer for this draft. For background on > Gen-ART, please see the FAQ at > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. > > Please resolve these comments along with any other Last Call comments > you may receive. > > Document: draft-ietf-dime-congestion-flow-attributes-01.txt > Reviewer: Brian Carpenter > Review Date: 2015-05-25 > IETF LC End Date: 2015-06-01 > IESG Telechat date: > > Summary: Ready > -------- > > Comment: > -------- > > This is a clear and well-written document. I do have two comments, however: > 1) I suggest that somebody with ECN smarts should glance at it (e.g. David > Black). > 2) The shepherd suggests in the writeup that it should formally update RFC > 5777. > But since it describes optional extensions to RFC 5777 that are strictly > compatible, > I don't think that's right. > > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art _______________________________________________ Gen-art mailing list Gen-art@ietf.org https://www.ietf.org/mailman/listinfo/gen-art
