On Mon, Nov 02, 2020 at 09:37:56PM +0100, Martin Liška wrote:
> > writing to ./gcc/testsuite/ChangeLog
> > empty group "()" found:"    * tree-vect-slp.c (): Update backedges in 
> > single-node cycles."
> > Traceback (most recent call last):
> >    File "../gcc-changelog/git_update_version.py", line 143, in <module>
> >      update_current_branch()
> >    File "../gcc-changelog/git_update_version.py", line 103, in 
> > update_current_branch
> >      not args.dry_mode)
> >    File "../gcc-changelog/git_update_version.py", line 39, in 
> > prepend_to_changelog_files
> >      raise AssertionError()
> > AssertionError
> > 
> > That's the Richard's commit that slipped through the verification, but
> > upsets ChangeLog generation.
> 
> Whoops! Sorry for that.
> 
> Please run the script manually with the following patch:
> 
> diff --git a/contrib/gcc-changelog/git_commit.py 
> b/contrib/gcc-changelog/git_commit.py
> index 1d0860cddd8..70cd2c5c2b3 100755
> --- a/contrib/gcc-changelog/git_commit.py
> +++ b/contrib/gcc-changelog/git_commit.py
> @@ -465,7 +465,7 @@ class GitCommit:
>                                  for needle in ('()', '[]', '<>'):
>                                      if ' ' + needle in parts[0]:
>                                          msg = f'empty group "{needle}" found'
> -                                        self.errors.append(Error(msg, line))
> +                                        # self.errors.append(Error(msg, 
> line))
>                              last_entry.lines.append(line)
>                      else:
>                          if last_entry.is_empty:
> 
> Then all should be fine as new error should not appear.

It isn't that easy (because update_version_git checks the gcc trunk and
so I had to insert a sh invocation in which I've tweaked it), but it worked,
thanks.  But something is really wrong with the hooks, as the gcc-cvs mail
for the trunk daily bump wasn't sent again (r10, r9 and r8 changes did).

        Jakub

Reply via email to