Re: gcc/DATESTAMP not updated any longer

[Martin Liška]

On 11/2/20 8:43 PM, Jakub Jelinek wrote:

On Mon, Nov 02, 2020 at 08:14:22PM +0100, Rainer Orth wrote:

I noticed that gcc/DATESTAMP isn't updated any longer after this
Friday.  I doubt this is intentional...

=== Working on: master ===
branch pulled and checked out
74 revisions since last Daily bump
writing to ./libstdc++-v3/ChangeLog
writing to ./gcc/ChangeLog
writing to ./gcc/testsuite/ChangeLog
writing to ./gcc/testsuite/ChangeLog
writing to ./gcc/cp/ChangeLog
writing to ./gcc/testsuite/ChangeLog
writing to ./gcc/ChangeLog
writing to ./gcc/testsuite/ChangeLog
writing to ./gcc/ChangeLog
writing to ./libgcc/ChangeLog
writing to ./gcc/ChangeLog
writing to ./gcc/ChangeLog
writing to ./gcc/testsuite/ChangeLog
empty group "()" found:" * tree-vect-slp.c (): Update backedges in single-node 
cycles."
Traceback (most recent call last):
   File "../gcc-changelog/git_update_version.py", line 143, in <module>
     update_current_branch()
   File "../gcc-changelog/git_update_version.py", line 103, in 
update_current_branch
     not args.dry_mode)
   File "../gcc-changelog/git_update_version.py", line 39, in 
prepend_to_changelog_files
     raise AssertionError()
AssertionError

That's the Richard's commit that slipped through the verification, but
upsets ChangeLog generation.

        Jakub

Whoops! Sorry for that.

Please run the script manually with the following patch:

diff --git a/contrib/gcc-changelog/git_commit.py 
b/contrib/gcc-changelog/git_commit.py
index 1d0860cddd8..70cd2c5c2b3 100755
--- a/contrib/gcc-changelog/git_commit.py
+++ b/contrib/gcc-changelog/git_commit.py
@@ -465,7 +465,7 @@ class GitCommit:
                                 for needle in ('()', '[]', '<>'):
                                     if ' ' + needle in parts[0]:
                                         msg = f'empty group "{needle}" found'
-                                        self.errors.append(Error(msg, line))
+                                        # self.errors.append(Error(msg, line))
                             last_entry.lines.append(line)
                     else:
                         if last_entry.is_empty:

Then all should be fine as new error should not appear.

Thanks,
Martin