On Mon, Nov 09, 2020 at 08:57:48AM +0100, Martin Liška wrote:
> On 11/6/20 8:59 PM, Jakub Jelinek wrote:
> > I think I'll work with Martin early next week to think about further spots
> > to add logging, so we narrow down where it is still called and where it
> > isn't.
>
> Hello.
>
> I'm suggesting to use the following extra logging.
Didn't tell much, I think we have the first missing mail and the log says
just:
post_receive_one:2020-11-09 20:12:24.268657: ref_name=refs/heads/master,
old_rev=3a5f8d745f8e26d973218b088788f22ad197ca67,
new_rev=38b17c27ce5a8e0cc5baa14697d4b5542b91b9d1
post_receive_one:2020-11-09 20:18:57.087896: ref_name=refs/heads/master,
old_rev=38b17c27ce5a8e0cc5baa14697d4b5542b91b9d1,
new_rev=83f1c165d2a2ebfba1164c730c0a65210fc4b285
gcc-...@gcc.gnu.org [gcc r11-4852] c++: Improve error location for class
using-decl.
gcc-...@gcc.gnu.org [gcc r11-4853] c++: Call tsubst_pack_expansion from tsubst.
post_receive_one:2020-11-09 20:32:41.238218: ref_name=refs/heads/master,
old_rev=83f1c165d2a2ebfba1164c730c0a65210fc4b285,
new_rev=6db082477ad839438c4b54fc61083276c68d47ec
post_receive_one:2020-11-09 21:10:36.565970: ref_name=refs/heads/master,
old_rev=6db082477ad839438c4b54fc61083276c68d47ec,
new_rev=32ff3309ae5a17b3a504aef3361a8c1c30e49f2c
gcc-...@gcc.gnu.org [gcc r11-4855] MAINTAINERS: Add myself for write after
approval
The missing r11-4854 commit is the 6db082477ad8394 one.
So I think either new_update must be raising an exception, or returning
None for some reason.
Bet we want to add logging for that exception, as well as for it returning
None and inside of it perhaps even more detailed logging on where it
returned None.
> >From a39631f6515b60ae2a3c8de0129b9920471df18b Mon Sep 17 00:00:00 2001
> From: marxin <mli...@suse.cz>
> Date: Mon, 9 Nov 2020 08:56:44 +0100
> Subject: [PATCH] Another debugging.
>
> ---
> sourceware/projects/src-home/git-hooks/hooks/post_receive.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sourceware/projects/src-home/git-hooks/hooks/post_receive.py
> b/sourceware/projects/src-home/git-hooks/hooks/post_receive.py
> index 0e931f8..37166e6 100644
> --- a/sourceware/projects/src-home/git-hooks/hooks/post_receive.py
> +++ b/sourceware/projects/src-home/git-hooks/hooks/post_receive.py
> @@ -18,6 +18,7 @@ from updates.factory import new_update
> from utils import debug, warn
>
> import traceback
> +import datetime
>
> def post_receive_one(ref_name, old_rev, new_rev, refs, submitter_email):
> """post-receive treatment for one reference.
> @@ -35,6 +36,9 @@ def post_receive_one(ref_name, old_rev, new_rev, refs,
> submitter_email):
> ' new_rev=%s)'
> % (ref_name, old_rev, new_rev))
>
> + with open("/tmp/gcc-git-mail.log", "a") as f:
> + ts = str(datetime.datetime.now())
> + f.write('post_receive_one:%s: ref_name=%s, old_rev=%s, new_rev=%s\n'
> % (ts, ref_name, old_rev, new_rev))
> update = new_update(ref_name, old_rev, new_rev, refs, submitter_email)
> if update is None:
> # We emit a warning, rather than trigger an assertion, because
> --
> 2.29.2
>
Jakub
