Paolo, Mike Stump's view was that darwin1 and darwin2 should be ignored since they can't build FSF gcc for other reasons. The idea was to fix these cases for the foreseeable future by using darwin[921]* as the match. I also tested the patch with a build of i686-apple-darwin9 and the results are posted at...
http://gcc.gnu.org/ml/gcc-testresults/2009-04/msg00911.html I have revised the log of the patch at... http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00693.html to mention the need for the double brackets as requested by Andrew Haley. Jack On Thu, Apr 09, 2009 at 03:05:33PM +0200, Paolo Bonzini wrote: > > > Mike Stump's recommendation on this issue is to use the match > > darwin[912]* to make sure that this is captured for darwin9 through > > darwin29. The idea is to not match darwin3 through darwin8. This usage > > is present in several places... > > > > http://gcc.gnu.org/ml/gcc-patches/2008-11/msg00333.html > > http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01532.html > > http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00177.html > > Ok, then using darwin[[912]]* is also fine. I misremembered darwin9 as > Tiger which was the first publicly distributed version supporting Intel > CPUs, wasn't it? > > Paolo