On Thu, Apr 09, 2009 at 11:35:36AM +0200, Paolo Bonzini wrote: > Jack Howarth wrote: > > I see one place where breakage may have occured... > > > > http://gcc.gnu.org/viewcvs/branches/gcc-4_4-branch/configure.ac?r1=144881&r2=144887 > > > > --- trunk/configure.ac 2009/03/16 13:23:13 144881 > > +++ trunk/configure.ac 2009/03/16 17:02:02 144887 > > @@ -446,11 +446,11 @@ > > *-*-chorusos) > > noconfigdirs="$noconfigdirs target-newlib target-libgloss ${libgcj}" > > ;; > > - powerpc-*-darwin* | x86_64-*-darwin[[912]]*) > > + powerpc-*-darwin*) > > noconfigdirs="$noconfigdirs ld gas gdb gprof" > > noconfigdirs="$noconfigdirs sim target-rda" > > ;; > > - i[[3456789]]86-*-darwin*) > > + i[[3456789]]86-*-darwin* | x86_64-*-darwin9*) > > noconfigdirs="$noconfigdirs ld gas gprof" > > noconfigdirs="$noconfigdirs sim target-rda" > > So, if removing the "9" is enough, the patch is preapproved for trunk > and 4.4. > > Paolo
Paolo, Mike Stump's recommendation on this issue is to use the match darwin[912]* to make sure that this is captured for darwin9 through darwin29. The idea is to not match darwin3 through darwin8. This usage is present in several places... http://gcc.gnu.org/ml/gcc-patches/2008-11/msg00333.html http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01532.html http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00177.html Jack
