I'm ok inasmuch as the relevant tests are shared between c/c++. "Iyer, Balaji V" <balaji.v.i...@intel.com> wrote:
[I included Jeff Law also in this conversation] > -----Original Message----- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Aldy Hernandez > Sent: Thursday, May 23, 2013 3:23 PM > To: Jakub Jelinek > Cc: Iyer, Balaji V; Richard Henderson; 'Joseph S. Myers'; 'gcc-patches' > Subject: Re: [PING]RE: [patch] cilkplus: Array notation for C patch > > On 05/23/13 14:03, Jakub Jelinek wrote: > > On Thu, May 23, 2013 at 06:27:04PM +0000, Iyer, Balaji V wrote: > >> gcc/testsuite/ChangeLog > >> 2013-05-23 Balaji V. Iyer <balaji.v.i...@intel.com> > >> > >> * gcc.dg/cilk-plus/array_notation/compile/array_test2.c: New test. > > > > I have concerns about the test locations, to me this looks way too > > deep tree, whether something is a compile test, or compile test > > expecting errors or runtime test is easily determined by { dg-do > > compile } vs. { dg-do run } and presence or lack of { dg-error ... } > > comments. So IMHO that level should be left out, plus I'd say the > > array_notation/ level is unnecessary as well, just put everything into > > c-c++-common/cilk-plus/an-*.c (except for tests that aren't going to > > be usable for C++, those can stay in gcc.dg/cilk-plus/an-*.c). Then > > gcc.dg/cilk-plus/*.exp would just ensure that tests from that > > directory are run and also from c-c++-common/ and later on the same > > would happen in g++.dg/cilk-plus/. In the future when you will need > > to link against runtime library cilk-plus.exp would just arrange for that > > to be > added to LD_LIBRARY_PATH, -L.../ etc. > > For the record, I agree. I got all your responses and, if I remove the compile, execute and errors directories but keep cilk-plus and array notation, maybe even abbreviate array notation to "an", (in future cilk keywords to "ck", pragma simd to "ps" and elemental function to "ef"), will that be OK with everyone? We removed one directory and moved 3 scripts to 1, and with abbreviated subdirectories the ChangeLog lines won't be long. I really like to put all the cilk-plus tests in one location for C compiler so that if anyone wants to get them I can point to one location. Thanks, Balaji V. Iyer.
