On 11/8/24 5:12 PM, Segher Boessenkool wrote: > On Fri, Nov 08, 2024 at 02:28:11PM -0600, Peter Bergner wrote: >> On 11/8/24 1:44 PM, Michael Meissner wrote: >>> diff --git a/gcc/config/rs6000/rs6000-arch.def >>> b/gcc/config/rs6000/rs6000-arch.def >>> new file mode 100644 >>> index 00000000000..e5b6e958133 >>> --- /dev/null >>> +++ b/gcc/config/rs6000/rs6000-arch.def >>> @@ -0,0 +1,48 @@ >>> +/* IBM RS/6000 CPU architecture features by processor type. >>> + Copyright (C) 1991-2024 Free Software Foundation, Inc. >>> + Contributed by Richard Kenner (ken...@vlsi1.ultra.nyu.edu) >> >> This doesn't make any sense to me. This is a new file with new >> code not copied form anywhere else, so why the Contributed by >> Richard Kenner line? Cut/paste error? > > If a file is largely copied from some other file, it makes sense to keep > attribution. If not, not.
Agreed and in this case, the file only contains uses of the new to this patch series ARCH_EXPAND(....) which is why I said the attribution to Richard doesn't make sense. Yes, the date should be changed to just 2024. Peter
