On Thu, Nov 14, 2024 at 06:26:11PM -0600, Peter Bergner wrote:
> On 11/8/24 1:49 PM, Michael Meissner wrote:
> > As part of the architecture flags patches, this patch changes the use of
> > TARGET_POPCNTB to TARGET_POWER5. The POPCNTB instruction was added in ISA
> > 2.02
> > (power5).
>
> I like what this patch and the other related clean up patches are doing,
> namely changing the TARGET_<MNEMONIC> macros to TARGET_<CPU> which makes
> much more sense. However, the way you ordered the patch series, this
> cleanup patch depends on the main patches that change us to using
> architecture flags, rather than the isa flags that require explicit
> machine options.
>
> I'd prefer (and I think Segher will too) that these cleanup patches be
> done *before* your main patches that change us to using architecture
> flags. That way they're independent of the main patches so if we had
> to revert those patches, then these cleanup patches would not have to
> be reverted too.
>
> So I'm speaking of patches 4/11, 5/11. 7/11 and 8/11. I don't see a
> 6/11. Did you forget to email that? Was that for changing TARGET_FOO
> to TARGET_POWER6? If so, then that should be handled like patches
> 4 thru 8.
Yes in the V2 version of the patches, I forgot to post patch #6. I posted it
in the V3 patches, that also included the fix if you did not specify a default
CPU on a LE system.
I have reformulated the patches, and I will be posting them shortly.
I will be splitting them into 4 groups.
The first patch set will provide TARGET_POWER{5,5X,6,7,8,9,10,11} based on the
current ISA bits. It just adds the define and then changes most of the uses.
The second path does not allow -mvsx to bump up the cpu to power7.
The third patch set after the TARGET_PATCH<x> set is applied adds the arch
masks, and removes the 3 switches used to set the arch bits, but are not
documented (-mpower8-internal, -mpower10, and -mpower11).
The fourth patch after the 3 above patch sets are applied adds the -mcpu=future
support.
--
Michael Meissner, IBM
PO Box 98, Ayer, Massachusetts, USA, 01432
email: meiss...@linux.ibm.com
