On Thu, Nov 14, 2024 at 06:26:11PM -0600, Peter Bergner wrote: > On 11/8/24 1:49 PM, Michael Meissner wrote: > > As part of the architecture flags patches, this patch changes the use of > > TARGET_POPCNTB to TARGET_POWER5. The POPCNTB instruction was added in ISA > > 2.02 > > (power5). > > I like what this patch and the other related clean up patches are doing, > namely changing the TARGET_<MNEMONIC> macros to TARGET_<CPU> which makes > much more sense. However, the way you ordered the patch series, this > cleanup patch depends on the main patches that change us to using > architecture flags, rather than the isa flags that require explicit > machine options. > > I'd prefer (and I think Segher will too) that these cleanup patches be > done *before* your main patches that change us to using architecture > flags. That way they're independent of the main patches so if we had > to revert those patches, then these cleanup patches would not have to > be reverted too. > > So I'm speaking of patches 4/11, 5/11. 7/11 and 8/11. I don't see a > 6/11. Did you forget to email that? Was that for changing TARGET_FOO > to TARGET_POWER6? If so, then that should be handled like patches > 4 thru 8.
See the 4 patch sets: Add more user friendly TARGET_ names for PowerPC https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669067.html Add support for -mcpu=future in the PowerPC https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669099.html Do not allow -mvsx to boost the cpu to power7 https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669106.html Separte PowerPC ISA bits from architecture bits set by -mcpu=<xxx> https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669108.html -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meiss...@linux.ibm.com
