On 11/8/23 04:09, Mary Bennett wrote:
gcc/ChangeLog:
* config/riscv/constraints.md: CVP2 -> CV_alu_pow2.
* config/riscv/corev.md: Likewise.
Bikeshedding alert... Usually we keep constraint names pretty small. It
helps when you've got patterns that may have many constraints. I don't
see that likely happening here, so I think we're OK. But something to
keep in mind.
2^n - 1 is a pretty common constraint and normally I might suggest we
make this more generic for use elsewhere. But in this case there's a
restriction on the upper bound of 0x3fffffff, so it's not as generic as
2^n - 1 up to word size.
So OK for the trunk as-is.
jeff
