Follow-up Comment #11, patch #5306 (project freeciv): >The variable names in do_expel_unit are confusing. I suggest using the words actor (for the unit doing the expulsion) and expelled (or target) in the variable names to make it clear who is who. Done (actor and target). >The even types E_MY_DIPLOMAT_BRIBE and E_ENEMY_DIPLOMAT_BRIBE in the notifications about expulsion are wrong. Use existing events or create new once if no one fits. Done.
#define SPECENUM_VALUE122 E_MY_DIPLOMAT_EXPEL #define SPECENUM_VALUE123 E_ENEMY_DIPLOMAT_EXPEL >Why never expel a unit to its capital? My mistake. I've edited... Can you check again? >The Xaw client needs the button added in the data too. ( See http://repo.or.cz/w/freeciv.git/commitdiff/25ee5735a91265bac09df12eb42dff2ca7037643 ) Well... It's not very "logic". Anyway it's done, but check please. >Update the documentation that foreign isn't hard coded. Done. (file #24683) _______________________________________________________ Additional Item Attachment: File name: expel_units.patch Size:18 KB _______________________________________________________ Reply to this item at: <http://gna.org/patch/?5306> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
