Follow-up Comment #3, patch #5306 (project freeciv):
--You shouldn't do anything in server/rscompat.c. It is for adding rules that
used to be hard coded to rulesets during ruleset version upgrade. Expel is a
new action.
Right!
--Your changes in aiair.c and aitools.c don't belong there. Expel isn't an
attack.
Right!
--do_expel_units() captures all units at the tile in stead of deporting them
to their capital.
I have a problem with capital, bool and struct...
--why did you make it an action against a unit stack rather than an action
against a single unit? What makes a unit stack target better than a unit
target for this action?
Because I've copied and pasted ''CAPTURE_UNITS'', the function more similar to
EXPEL_UNITS. Now I understand your feedback and I hope it's correct now...
(file #24669)
_______________________________________________________
Additional Item Attachment:
File name: expel_units.patch Size:17 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?5306>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
