Follow-up Comment #17, patch #5306 (project freeciv):
>Why "WIN_" in event the names? Suggestions: E_UNIT_WAS_EXPELLED
E_UNIT_DID_EXPEL
Done.
>Not sure what you mean here. If you want me to explain I need to know
specifically what you want me to explain. Or did you ask me to finish
do_expel_unit() for you?
No. Just a moment of sadness and anger. The "order" or "disposition" is
correct?
>Could return NULL if no city is found. NULL -> crash. You should check for
NULL and handle it. Aborting is an OK way of handling it.
Done.
>Don't add diplomat_escape_full. The actor doesn't escape. No need. He just
expelled someone.
Done.
(file #24697)
_______________________________________________________
Additional Item Attachment:
File name: expel_units.patch Size:16 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?5306>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
