On 6/4/2017 1:08 PM, James Almer wrote: > This test the demuxer discarding non ADTS frames at the beginning and > end of the input. > > As a side effect, this commit also enables fate-adts-demux, which was > accidentally disabled in 324f0fbff1245f9e9e1dda29ecb03138a2de287d. > > Signed-off-by: James Almer <jamr...@gmail.com> > --- > Sample is in http://0x0.st/6gI.aac
I could instead use a smaller sample (with say 10 or so frames) to use framecrc instead of crc and not end up with a huge ref file, but such a small sample with garbage data before the first adts frame ends up having a probing score of 1. According to lcov there's already a test with a file that also probes with a score of 1, so should i assume it's safe or would it be too fragile? Worst case I could just force the aac demuxer in the test i guess. > > Should be renamed to id3v1.aac and placed in the aac folder. > > tests/fate/demux.mak | 3 ++- > tests/ref/fate/adts-id3v1-demux | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > create mode 100644 tests/ref/fate/adts-id3v1-demux > > diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak > index cf69e2fe2c..f3e054f90b 100644 > --- a/tests/fate/demux.mak > +++ b/tests/fate/demux.mak > @@ -1,8 +1,9 @@ > FATE_SAMPLES_DEMUX-$(call DEMDEC, AVI, FRAPS) += fate-avio-direct > fate-avio-direct: CMD = framecrc -avioflags direct -i > $(TARGET_SAMPLES)/fraps/fraps-v5-bouncing-balls-partial.avi -avioflags direct > > -FATE_SAMPLES_DEMUX-$(DEMDEC, AAC, AAC) += fate-adts-demux > +FATE_SAMPLES_DEMUX-$(call DEMDEC, AAC, AAC) += fate-adts-demux > fate-adts-id3v1-demux > fate-adts-demux: CMD = crc -i $(TARGET_SAMPLES)/aac/ct_faac-adts.aac -acodec > copy > +fate-adts-id3v1-demux: CMD = crc -i $(TARGET_SAMPLES)/aac/id3v1.aac -acodec > copy > > FATE_SAMPLES_DEMUX-$(CONFIG_AEA_DEMUXER) += fate-aea-demux > fate-aea-demux: CMD = crc -i $(TARGET_SAMPLES)/aea/chirp.aea -acodec copy > diff --git a/tests/ref/fate/adts-id3v1-demux b/tests/ref/fate/adts-id3v1-demux > new file mode 100644 > index 0000000000..f201d80bcd > --- /dev/null > +++ b/tests/ref/fate/adts-id3v1-demux > @@ -0,0 +1 @@ > +CRC=0x302a4a48 > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
