On Mon, Nov 28, 2016 at 01:13:41PM -0600, Kyle Swanson wrote: > On Thu, Nov 17, 2016 at 11:04 AM, Kyle Swanson <k...@ylo.ph> wrote: > > Hi, > > > > Here's a couple of patches which update the ebur128 filter to use the > > recently added ebur128 API. This updated filter allows fine-tuned > > control over which EBU R128 parameters are measured, and provides > > modest speed increases over the previous ebur128 filter. Also > > noteworthy: this removes the video output option of the ebur128 > > filter. This is extraneous for an ebur128 measurement filter IMHO, but > > if we wanted to keep similar functionality in FFmpeg, we'd be better > > served by a new video source filter where custom meters could be > > created via exported frame metadata. > > > > The first patch adds true peak functionality to the ebur128 API using > > swresample (this was already discussed a little bit: > > http://ffmpeg.org/pipermail/ffmpeg-devel/2016-November/202583.html) > > The second patch is an update to the ebur128 filter. > > > > Kyle > > Does anyone have any problems with the first patch?
i see some compiler warnings: CC libavfilter/ebur128.o libavfilter/ebur128.c: In function ‘ebur128_init_resampler’: libavfilter/ebur128.c:233:9: warning: variable ‘errcode’ set but not used [-Wunused-but-set-variable] libavfilter/ebur128.c: In function ‘ff_ebur128_init’: libavfilter/ebur128.c:358:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] (there are 2 more that were present before) CC libavfilter/ebur128.o libavfilter/ebur128.c: In function ‘ebur128_gated_loudness.part.7’: libavfilter/ebur128.c:382:20: warning: ‘relative_threshold’ may be used uninitialized in this function [-Wuninitialized] libavfilter/ebur128.c:548:12: note: ‘relative_threshold’ was declared here libavfilter/ebur128.c:565:8: warning: ‘above_thresh_counter’ may be used uninitialized in this function [-Wuninitialized] [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is the form of government in which you can choose your dictator
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
