Hi Jan, 2015ko azaroak 3an, Jan Malakhovski-ek idatzi zuen:
[...] > diff --git a/lisp/org.el b/lisp/org.el > index c466870..cf0ef1f 100755 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -9960,7 +9960,7 @@ active region." > (car org-stored-links)))))) > > (defun org-store-link-props (&rest plist) > - "Store link properties, extract names and addresses." > + "Store link properties, extract names, addresses and dates." > (let (x adr) > (when (setq x (plist-get plist :from)) > (setq adr (mail-extract-address-components x)) > @@ -9969,7 +9969,18 @@ active region." > (when (setq x (plist-get plist :to)) > (setq adr (mail-extract-address-components x)) > (setq plist (plist-put plist :toname (car adr))) > - (setq plist (plist-put plist :toaddress (nth 1 adr))))) > + (setq plist (plist-put plist :toaddress (nth 1 adr)))) > + (when (setq x (plist-get plist :date)) > + (setq plist (plist-put plist :date-timestamp > + (ignore-errors > + (format-time-string > + (org-time-stamp-format t) > + (date-to-time x))))) > + (setq plist (plist-put plist :date-timestamp-inactive > + (ignore-errors > + (format-time-string > + (org-time-stamp-format t t) > + (date-to-time x))))))) Can you introduce a let binding so that (date-to-time x) is only called once? Also, what is ignore-errors protecting? The call to date-to-time, or format-time-string? I think the scope of ignore-errors should be as narrow as it can be. -- Aaron Ecay
