On 9/18/25 21:02, Yonghang Wang wrote:
It seems the best is to request a cmake build of zstd...  zstd does support cmake but for now only make is being used to build.


I filed a PR for that 2 years ago, but never got a response :(

https://src.fedoraproject.org/rpms/zstd/pull-request/7

Just rebased it again.


On Thu, Sep 18, 2025 at 8:45 PM Luya Tshimbalanga <[email protected] <mailto:[email protected]>> wrote:

    __

    Hello team,

    Upstream made a change with their version 2.10.1 meaning some major
    change in the attached spec file. I hit an issue with the linked
    scratch build [1] related to "zstd". Could someone help to improve
    the spec file? Thanks in advance.

    Here is the full spec in case attachment fails:

    %undefine __cmake_in_source_build
    %bcond          conan 0

    Name:           luxcorerender
    Version:        2.10.1
    Release:        %autorelease
    Summary:        Physically based unbiased rendering system

    License:        Apache-2.0
    URL: https://luxcorerender.org/ <https://luxcorerender.org/>
    Source0: https://github.com/% <https://github.com/%>{name}/LuxCore/
    archive/wheels-v%{version}%{?prerelease}/%{name}-%{version}.tar.gz
    Source1: https://github.com/% <https://github.com/%>{name}/
    BlendLuxCore/archive/v%{version}%{?prerelease}/blendluxcore-
    %{version}.tar.gz
    Source3:        org.%{name}.blendluxcore.metainfo.xml

    # Essential system integration patch
    #Patch3:         LuxCore-system-bcd.patch

    ExclusiveArch:  x86_64

    BuildRequires:  cmake
    BuildRequires:  gcc-c++
    %if %{with conan}
    BuildRequires:  conan
    %endif
    BuildRequires:  pybind11-devel
    BuildRequires:  blender-rpm-macros
    # Upstream currently lacks compatibility with minizip-ng
    BuildRequires:  pkgconfig(minizip)

    # Core rendering dependencies
    BuildRequires:  bcd-devel
    BuildRequires:  boost-devel
    BuildRequires:  embree-devel
    BuildRequires:  openvdb-devel
    BuildRequires:  oidn-devel
    BuildRequires:  pkgconfig(blosc2)
    BuildRequires:  pkgconfig(bzip2)
    BuildRequires:  pkgconfig(liblzma)
    BuildRequires:  pkgconfig(tbb)
    BuildRequires:  pkgconfig(glfw3)
    BuildRequires:  pkgconfig(spdlog)
    BuildRequires:  pkgconfig(libzstd)
    BuildRequires:  cmake(OpenColorIO)
    BuildRequires:  cmake(OpenImageIO)
    BuildRequires:  cmake(OpenEXR)
    BuildRequires:  cmake(opensubdiv)

    %description
    LuxCoreRender implements state-of-the-art light transport algorithms
    for
    photorealistic rendering. Features hybrid CPU/GPU acceleration,
    spectral rendering, and advanced material modeling.

    %package core
    Summary:        Core runtime components
    Obsoletes:      LuxRender-core < 2.0

    %description core
    Contains the main rendering engine and essential libraries for scene
    processing
    and light simulation.

    %package -n blender-%{name}
    Summary:        Blender 4.2+ integration plugin
    Requires:       %{name}%{?_isa} = %{version}-%{release}

    %description -n blender-%{name}
    Blender extension for exporting scenes and materials to LuxCore
    Renderer.
    Supports Cycles material conversion and interactive rendering.

    %package devel
    Summary:        Development headers and libraries
    Requires:       %{name}-core%{?_isa} = %{version}-%{release}

    %description devel
    Header files and build configuration for developing LuxCore-based
    applications.

    %prep
    %autosetup -p1 -a1 -n LuxCore-wheels-v%{version}

    %build
    %cmake \
         -DBUILD_SHARED_LIBS=ON \
         -DCMAKE_CXX_STANDARD=20 \
         -DLUXCOREDEPS_VERSION=0 \
         -DPYLUXCORE_BINDINGS=ON \
         -Dzstd_DIR=%{_libdir}/libzstd.so \
         -Dzstd_INCLUDEDIR=%{_includedir}
    %cmake_build

    %install
    pushd %{_vpath_builddir}
    mkdir -p %{buildroot}%{_bindir}
    mkdir -p %{buildroot}%{_datadir}/%{name}
    mkdir -p %{buildroot}%{_libdir}
    mkdir -p %{buildroot}%{_includedir}

    install -Dpm 0755 bin/* %{buildroot}%{_bindir}/
    install -Dpm 0755 lib/*.{a,so*} %{buildroot}%{_libdir}/

    # Remove rpaths
    chrpath --delete %{buildroot}%{_bindir}/*
    chrpath --delete %{buildroot}%{_libdir}/*.so*

    # Install include files
    cp -pr generated/include/{luxcore,luxrays}
    %{buildroot}%{_includedir} #cfg.h
    popd
    cp -pr include/{luxcore,luxrays} %{buildroot}%{_includedir}/
    rm %{buildroot}%{_includedir}/{luxcore,luxrays}/cfg.h.in <http://
    cfg.h.in>

    # Relocate pyluxcore
    mkdir -p %{buildroot}%{python3_sitearch}
    mv %{buildroot}%{_libdir}/pyluxcore.so %{buildroot}%{python3_sitearch}

    # Import add-ons and preset
    mkdir -p %{buildroot}%{blender_extensions}/%{name}
    cp -a BlendLuxCore-blendluxcore_v%{version}/*
    %{buildroot}%{blender_extensions}/%{name}
    install -Dpm 644 %{SOURCE3} %{buildroot}%{_metainfodir}/org.
    %{name}.blendluxcore.metainfo.xml

    %check
    appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/*.xml

    %files
    %license LICENSE
    %doc README.md AUTHORS

    %files core
    %{_bindir}/luxcore*
    %{_libdir}/liblux*.so.*

    %files -n blender-%{name}
    %{_metainfodir}/org.%{name}.*.xml
    /%{blender_extensions}/%{name}

    %files devel
    %{_includedir}/{luxcore,luxrays}
    %{_libdir}/pkgconfig/*.pc

    %changelog
    %autochangelog

    Reference:

    [1]

    koji.fedoraproject.org <http://koji.fedoraproject.org>

    build (rawhide, luxcorerender-2.10.1-1.fc44.src.rpm) | Task Info |
    koji <#m_5150576771393409577_>

    🔗 https://koji.fedoraproject.org/koji/taskinfo?taskID=137240286
    <https://koji.fedoraproject.org/koji/taskinfo?taskID=137240286>

    [2]

-- Luya Tshimbalanga
    Fedora Design Team
    Fedora Design Suite maintainer

    ____ --
    _______________________________________________
    devel mailing list -- [email protected]
    <mailto:[email protected]>
    To unsubscribe send an email to [email protected]
    <mailto:[email protected]>
    Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/
    project/code-of-conduct/ <https://docs.fedoraproject.org/en-US/
    project/code-of-conduct/>
    List Guidelines: https://fedoraproject.org/wiki/
    Mailing_list_guidelines <https://fedoraproject.org/wiki/
    Mailing_list_guidelines>
    List Archives: https://lists.fedoraproject.org/archives/list/
    [email protected] <https://lists.fedoraproject.org/
    archives/list/[email protected]>
    Do not reply to spam, report it: https://pagure.io/fedora-
    infrastructure/new_issue <https://pagure.io/fedora-infrastructure/
    new_issue>




--
Orion Poplawski
he/him/his  - surely the least important thing about me
IT Systems Manager                         720-772-5637
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       [email protected]
Boulder, CO 80301                 https://www.nwra.com/
--
_______________________________________________
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to