On Wed, Jan 29, 2025 at 03:33:25PM +0000, Zbigniew Jędrzejewski-Szmek wrote:
> On Wed, Jan 29, 2025 at 02:59:04PM +0000, Daniel P. Berrangé wrote:
> > On Wed, Jan 29, 2025 at 02:16:06PM +0000, Zbigniew Jędrzejewski-Szmek wrote:
> > > On Sat, Jan 25, 2025 at 11:04:54AM +0000, Zbigniew Jędrzejewski-Szmek
> > > wrote:
> > > > On Sat, Jan 25, 2025 at 10:16:01AM +0000, Zbigniew Jędrzejewski-Szmek
> > > > wrote:
> > > > > But I see that I didn't add packages that just call
> > > > > %{sysusers_create_compat} to my list.
> > > >
> > > > Updated diff:
> > > > https://in.waw.pl/~zbyszek/fedora/sysusers_mass_spec_change_v2.diff.html
> > > > That brings up the total to 343 packages.
> > >
> > > Updated diff:
> > > https://in.waw.pl/~zbyszek/fedora/sysusers_mass_spec_change_v3.diff.html
> > > That brings up the total to 365 packages.
> >
> > The change to libvirt.spec is incorrect, please omit that. We already
> > install a sysusers file as part of the build process. We *also* had the
> > useradd %post logic because the systemd sysusers macros didn't work for
> > our use case, but if RPM now auto-detects installed sysusers files, we
> > can just drop the %post bits with no replacement.
>
> Are you sure? The patch adds a *second* file with 'g libvirt -'.
> The existing file creates groups kvm, qemu and user qemu.
Opps, I didn't see that we missed the 'libvirt' group. I'll fix that
upstream and backport to Fedora.
> Most of the patch is indeed about dropping the %pre scriptlet.
We won't actually drop this, we'll just make it conditional to exclude
Fedora >= 42, since we keep the specfile in sync across multiple
streams.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
