On 02/26/20 06:05, Dong, Eric wrote: > Hi Leo, > > Yes, I means you also change the cod position in the c file, so in the patch > file, it seems like it has other changes. > My recommendation is to refine the patch to not change the code postion.
Indeed I noticed that too. I figured this change -- moving the code around, beyond purely making it public -- was intentional. I assumed the new position of the function within the source code made more sense to Leo. I agree the code movement should be explained at least in the commit message. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54853): https://edk2.groups.io/g/devel/message/54853 Mute This Topic: https://groups.io/mt/71541518/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
