This patch set fixes an issue introduced recently in MpInitLib, where we read a PlatformId MSR that is not implemented on AMD processors.
The proposed solution is to export the StandardSignatureIsAuthenticAMD function from LocalApicLib, so that it may be used by MpInitLib or any other module that consumes LocalApicLib. Alternatively, we considered creating a new library, but opted against it as that would incur quite a bit of churning across modules that consume MpInitLib. BTW, reading the PlatformId MSR was already being done by MicrocodeDetect(), but it never affected AMD-based platforms as the flow never gets that far, since the Detect routine bails out early when it finds the size of the patch is zero. Leo Duran (2): UefiCpuPkg: LocalApicLib: Export StandardSignatureIsAuthenticAMD function UefiCpuPkg: MpInitLib: Exclude code no pertinent to AMD processors. UefiCpuPkg/Include/Library/LocalApicLib.h | 15 +++++++ UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 47 +++++++++++----------- .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 47 +++++++++++----------- UefiCpuPkg/Library/MpInitLib/Microcode.c | 17 +++++++- UefiCpuPkg/Library/MpInitLib/MpLib.c | 11 ++++- 5 files changed, 87 insertions(+), 50 deletions(-) -- 2.7.4 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54797): https://edk2.groups.io/g/devel/message/54797 Mute This Topic: https://groups.io/mt/71541516/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-