Leo, > > BTW, reading the PlatformId MSR was already being done by MicrocodeDetect(), > > but it never affected AMD-based platforms as the flow never gets that far, > > since > > the Detect routine bails out early when it finds the size of the patch is > > zero.
You are saying that PlatformId MSR access is not performed by CPU in old code because of the zero size uCode. But now with Hao or Siyuan's change, the PlatformId MSR access is always performed even when there is no uCode. It sounds like a regression to optimization to me. Did you evaluate the path to avoid accessing PlatformID MSR when uCode doesn't exist? So that the API to detect AMD processor is not needed at all. Thanks, Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54841): https://edk2.groups.io/g/devel/message/54841 Mute This Topic: https://groups.io/mt/71541516/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
