Reviewed-by: jiewen....@intel.com
> -----Original Message-----
> From: Philippe Mathieu-Daude <phi...@redhat.com>
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <co...@gmx.fr>; Yao, Jiewen <jiewen....@intel.com>;
> Zhang, Chao B <chao.b.zh...@intel.com>; Philippe Mathieu-Daude
> <phi...@redhat.com>
> Subject: [PATCH v2 70/78] SignedCapsulePkg/Universal: Fix various typos
>
> From: Antoine Coeur <co...@gmx.fr>
>
> Fix various typos in documentation, comments and debug strings.
>
> Cc: Jiewen Yao <jiewen....@intel.com>
> Cc: Chao Zhang <chao.b.zh...@intel.com>
> Signed-off-by: Antoine Coeur <co...@gmx.fr>
> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <phi...@redhat.com>
> ---
> .../SystemFirmwareUpdate/SystemFirmwareDxe.h | 2 +-
> .../RecoveryModuleLoadPei/ParseConfigProfile.c | 2 +-
> .../RecoveryModuleLoadPei/RecoveryModuleLoadPei.c | 14 +++++++-------
> .../SystemFirmwareUpdate/ParseConfigProfile.c | 2 +-
> .../SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 4 ++--
> .../SystemFirmwareUpdate/SystemFirmwareReportDxe.c | 8 ++++----
> .../SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 4 ++--
> 7 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
> index f7166e337ad7..d3cc89e5f106 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
> @@ -113,7 +113,7 @@ typedef struct {
>
> #define ABORT_REASON_MAX_SIZE 0x40 // UnicodeStringSize
> including
> final L'\0'
>
> -#define CAPSULE_IMAGE_ADDITIONAL_MAX_SIZE (0x20020 + 0xA0000) //
> Addtional size for Capsule Header, FV block alignment + DispatchImage.
> +#define CAPSULE_IMAGE_ADDITIONAL_MAX_SIZE (0x20020 + 0xA0000) //
> Additional size for Capsule Header, FV block alignment + DispatchImage.
>
> typedef struct {
> UINT8 ImageIndex;
> diff --git
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
> index ee9787a2bf53..5cd690ddeb76 100644
> ---
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
> +++
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
> @@ -103,7 +103,7 @@ ParseRecoveryDataFile (
> //
>
> //
> - // FileBuid
> + // FileGuid
> //
> Status = GetGuidFromDataFile(
> Context,
> diff --git
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadP
> ei.c
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadP
> ei.c
> index eda3cc542068..53b821c2bb26 100644
> ---
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadP
> ei.c
> +++
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadP
> ei.c
> @@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include <Uefi.h>
> #include <PiPei.h>
> //
> -// The protocols, PPI and GUID defintions for this module
> +// The protocols, PPI and GUID definitions for this module
> //
> #include <Ppi/MasterBootMode.h>
> #include <Ppi/BootInRecoveryMode.h>
> @@ -144,7 +144,7 @@ IsFmpCapsuleGuid (
> }
>
> /**
> - This function assumes the input Capusule image already passes basic check
> in
> + This function assumes the input Capsule image already passes basic check in
> ValidateFmpCapsule().
>
> Criteria of system FMP capsule is:
> @@ -235,7 +235,7 @@ IsValidCapsuleHeader (
> @param[out] IsSystemFmp If it is a system FMP.
> @param[out] EmbeddedDriverCount The EmbeddedDriverCount in the FMP
> capsule.
>
> - @retval EFI_SUCESS Input capsule is a correct FMP capsule.
> + @retval EFI_SUCCESS Input capsule is a correct FMP capsule.
> @retval EFI_INVALID_PARAMETER Input capsule is not a correct FMP capsule.
> **/
> EFI_STATUS
> @@ -398,7 +398,7 @@ InitializeRecoveryModule (
> @param[in] FvImage Points to the DXE FV image.
> @param[in] FvImageSize The length of the DXE FV image in bytes.
>
> - @retval EFI_SUCESS Create hob and install FvInfo PPI
> successfully.
> + @retval EFI_SUCCESS Create hob and install FvInfo PPI
> successfully.
> @retval EFI_VOLUME_CORRUPTED The input data is not an FV.
> @retval EFI_OUT_OF_RESOURCES No enough resource to process the input
> data.
> **/
> @@ -479,7 +479,7 @@ CreateHobForRecoveryCapsule (
> @param[in] ConfigImage Points to the config file image.
> @param[in] ConfigImageSize The length of the config file image in
> bytes.
>
> - @retval EFI_SUCESS Process Recovery Image successfully.
> + @retval EFI_SUCCESS Process Recovery Image successfully.
> **/
> EFI_STATUS
> RecoverImage (
> @@ -554,7 +554,7 @@ RecoverImage (
> @param[in] Image Points to the recovery image.
> @param[in] Length The length of the recovery image in bytes.
>
> - @retval EFI_SUCESS Process Recovery Image successfully.
> + @retval EFI_SUCCESS Process Recovery Image successfully.
> @retval EFI_SECURITY_VIOLATION Recovery image is not processed due to
> security violation.
> **/
> EFI_STATUS
> @@ -607,7 +607,7 @@ ProcessRecoveryImage (
> @param[in] CapsuleHeader Points to a capsule header.
> @param[in] IsSystemFmp If this capsule is a system FMP capsule.
>
> - @retval EFI_SUCESS Process Capsule Image successfully.
> + @retval EFI_SUCCESS Process Capsule Image successfully.
> @retval EFI_UNSUPPORTED Capsule image is not supported by the
> firmware.
> @retval EFI_VOLUME_CORRUPTED FV volume in the capsule is corrupted.
> @retval EFI_OUT_OF_RESOURCES Not enough memory.
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/ParseConfigProfile.c
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/ParseConfigProfile.c
> index 7d414b07fbc4..878c6680a338 100644
> --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/ParseConfigProfile.c
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/ParseConfigProfile.c
> @@ -153,7 +153,7 @@ ParseUpdateDataFile (
> (*UpdateArray)[Index].BaseAddress = (EFI_PHYSICAL_ADDRESS) Num64;
>
> //
> - // FileBuid
> + // FileGuid
> //
> Status = GetGuidFromDataFile(
> Context,
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareComm
> onDxe.c
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareComm
> onDxe.c
> index d377a8d05665..1b6d7e78eaa1 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareComm
> onDxe.c
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareComm
> onDxe.c
> @@ -331,8 +331,8 @@ InitializePrivateData (
> &VarSize,
> &SystemFmpPrivate->LastAttempt
> );
> - DEBUG((DEBUG_INFO, "GetLastAttemp - %r\n", VarStatus));
> - DEBUG((DEBUG_INFO, "GetLastAttemp Version - 0x%x, State - 0x%x\n",
> SystemFmpPrivate->LastAttempt.LastAttemptVersion, SystemFmpPrivate-
> >LastAttempt.LastAttemptStatus));
> + DEBUG((DEBUG_INFO, "GetLastAttempt - %r\n", VarStatus));
> + DEBUG((DEBUG_INFO, "GetLastAttempt Version - 0x%x, State - 0x%x\n",
> SystemFmpPrivate->LastAttempt.LastAttemptVersion, SystemFmpPrivate-
> >LastAttempt.LastAttemptStatus));
>
> return EFI_SUCCESS;
> }
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReport
> Dxe.c
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReport
> Dxe.c
> index ffd9d1f25bfb..ebd1d0d53db8 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReport
> Dxe.c
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReport
> Dxe.c
> @@ -30,7 +30,7 @@ SYSTEM_FMP_PRIVATE_DATA *mSystemFmpPrivate =
> NULL;
> @param[out] LastAttemptVersion The last attempt version, which will be
> recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
> @param[out] LastAttemptStatus The last attempt status, which will be
> recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
>
> - @retval EFI_SUCESS Process Capsule Image successfully.
> + @retval EFI_SUCCESS Process Capsule Image successfully.
> @retval EFI_UNSUPPORTED Capsule image is not supported by the
> firmware.
> @retval EFI_VOLUME_CORRUPTED FV volume in the capsule is corrupted.
> @retval EFI_OUT_OF_RESOURCES Not enough memory.
> @@ -174,7 +174,7 @@ FmpSetImage (
> // Process FV
> //
> Status = DispatchSystemFmpImages((VOID *)Image, ImageSize,
> &SystemFmpPrivate->LastAttempt.LastAttemptVersion, &SystemFmpPrivate-
> >LastAttempt.LastAttemptStatus);
> - DEBUG((DEBUG_INFO, "(Agent)SetImage - LastAttemp Version - 0x%x, State -
> 0x%x\n", SystemFmpPrivate->LastAttempt.LastAttemptVersion,
> SystemFmpPrivate->LastAttempt.LastAttemptStatus));
> + DEBUG((DEBUG_INFO, "(Agent)SetImage - LastAttempt Version - 0x%x, State
> - 0x%x\n", SystemFmpPrivate->LastAttempt.LastAttemptVersion,
> SystemFmpPrivate->LastAttempt.LastAttemptStatus));
> if (EFI_ERROR(Status)) {
> VarStatus = gRT->SetVariable(
> SYSTEM_FMP_LAST_ATTEMPT_VARIABLE_NAME,
> @@ -183,7 +183,7 @@ FmpSetImage (
> sizeof(SystemFmpPrivate->LastAttempt),
> &SystemFmpPrivate->LastAttempt
> );
> - DEBUG((DEBUG_INFO, "(Agent)SetLastAttemp - %r\n", VarStatus));
> + DEBUG((DEBUG_INFO, "(Agent)SetLastAttempt - %r\n", VarStatus));
> return Status;
> }
>
> @@ -211,7 +211,7 @@ FmpSetImage (
> sizeof(SystemFmpPrivate->LastAttempt),
> &SystemFmpPrivate->LastAttempt
> );
> - DEBUG((DEBUG_INFO, "(Agent)SetLastAttemp - %r\n", VarStatus));
> + DEBUG((DEBUG_INFO, "(Agent)SetLastAttempt - %r\n", VarStatus));
> return Status;
> }
> }
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdate
> Dxe.c
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdate
> Dxe.c
> index c302f750e2fd..bdb70bdb32cc 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdate
> Dxe.c
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdate
> Dxe.c
> @@ -493,7 +493,7 @@ FmpSetImage (
> // the current variable driver may not manage the new NVRAM region.
> //
> if (mNvRamUpdated) {
> - DEBUG ((DEBUG_INFO, "NvRamUpdated, Update Variable Serivces\n"));
> + DEBUG ((DEBUG_INFO, "NvRamUpdated, Update Variable Services\n"));
> gRT->GetVariable = GetVariableHook;
> gRT->GetNextVariableName = GetNextVariableNameHook;
> gRT->SetVariable = SetVariableHook;
> @@ -514,7 +514,7 @@ FmpSetImage (
> sizeof(SystemFmpPrivate->LastAttempt),
> &SystemFmpPrivate->LastAttempt
> );
> - DEBUG((DEBUG_INFO, "SetLastAttemp - %r\n", VarStatus));
> + DEBUG((DEBUG_INFO, "SetLastAttempt - %r\n", VarStatus));
>
> return Status;
> }
> --
> 2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52821): https://edk2.groups.io/g/devel/message/52821
Mute This Topic: https://groups.io/mt/69396188/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
