Reviewed-by: Eric Dong <eric.d...@intel.com> I'm not sure whether you can submit the changes. If you need my help to check in the code for UefiCpuPkg, please send mail to me.
Thanks, Eric > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Philippe Mathieu-Daudé > Sent: Friday, January 3, 2020 5:08 PM > To: devel@edk2.groups.io > Cc: Antoine Coeur <co...@gmx.fr>; Dong, Eric <eric.d...@intel.com>; Ni, > Ray <ray...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Philippe > Mathieu-Daude <phi...@redhat.com> > Subject: [edk2-devel] [PATCH v2 77/78] UefiCpuPkg/PiSmm: Fix various > typos > > From: Antoine Coeur <co...@gmx.fr> > > Fix various typos in comments and documentation. > > Cc: Eric Dong <eric.d...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Signed-off-by: Antoine Coeur <co...@gmx.fr> > Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > Reviewed-by: Eric Dong <eric.d...@intel.com> > Signed-off-by: Philippe Mathieu-Daude <phi...@redhat.com> > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 12 ++++++---- > -- > .../PiSmmCommunication/PiSmmCommunicationPei.c | 2 +- > .../PiSmmCommunication/PiSmmCommunicationSmm.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 4 ++-- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 4 ++-- > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 6 +++--- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 2 +- > 9 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > index 33b3dd140ea7..fe7e8b0323b8 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > @@ -284,7 +284,7 @@ extern UINT8 mSmmSaveStateRegisterLma; > > @retval EFI_SUCCESS The register was read from Save State > @retval EFI_NOT_FOUND The register is not defined for the Save State of > Processor > - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. > + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. > > **/ > EFI_STATUS > @@ -308,7 +308,7 @@ SmmReadSaveState ( > > @retval EFI_SUCCESS The register was written from Save State > @retval EFI_NOT_FOUND The register is not defined for the Save State of > Processor > - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct > + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct > > **/ > EFI_STATUS > @@ -336,7 +336,7 @@ This function supports reading a CPU Save State > register in SMBase relocation ha > > @retval EFI_SUCCESS The register was read from Save State. > @retval EFI_NOT_FOUND The register is not defined for the Save State > of Processor. > -@retval EFI_INVALID_PARAMTER This or Buffer is NULL. > +@retval EFI_INVALID_PARAMETER This or Buffer is NULL. > > **/ > EFI_STATUS > @@ -363,7 +363,7 @@ This function supports writing a CPU Save State > register in SMBase relocation ha > > @retval EFI_SUCCESS The register was written to Save State. > @retval EFI_NOT_FOUND The register is not defined for the Save State > of Processor. > -@retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct. > +@retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct. > > **/ > EFI_STATUS > @@ -1263,7 +1263,7 @@ EdkiiSmmGetMemoryAttributes ( > > /** > This function fixes up the address of the global variable or function > - referred in SmmInit assembly files to be the absoute address. > + referred in SmmInit assembly files to be the absolute address. > **/ > VOID > EFIAPI > @@ -1272,7 +1272,7 @@ PiSmmCpuSmmInitFixupAddress ( > > /** > This function fixes up the address of the global variable or function > - referred in SmiEntry assembly files to be the absoute address. > + referred in SmiEntry assembly files to be the absolute address. > **/ > VOID > EFIAPI > diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c > b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c > index 5d09130e5591..68e5003ad4c2 100644 > --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c > +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c > @@ -366,7 +366,7 @@ Communicate ( > @param FileHandle Handle of the file being invoked. > @param PeiServices Pointer to PEI Services table. > > - @retval EFI_SUCEESS > + @retval EFI_SUCCESS > @return Others Some error occurs. > **/ > EFI_STATUS > diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c > b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c > index 6be12d6c14cd..30f7d57bdd91 100644 > --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c > +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c > @@ -155,7 +155,7 @@ AllocateAcpiNvsMemoryBelow4G ( > @param[in] ImageHandle Image handle of this driver. > @param[in] SystemTable A Pointer to the EFI System Table. > > - @retval EFI_SUCEESS > + @retval EFI_SUCCESS > @return Others Some error occurs. > **/ > EFI_STATUS > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > index 723fd5042ff4..db68e1316ec5 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > @@ -215,7 +215,7 @@ DumpModuleInfoByIp ( > > @retval EFI_SUCCESS The register was read from Save State > @retval EFI_NOT_FOUND The register is not defined for the Save State of > Processor > - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. > + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. > > **/ > EFI_STATUS > @@ -287,7 +287,7 @@ SmmReadSaveState ( > > @retval EFI_SUCCESS The register was written from Save State > @retval EFI_NOT_FOUND The register is not defined for the Save State of > Processor > - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct > + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct > > **/ > EFI_STATUS > diff --git > a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > index 55090e9c3e4f..9c5a92af6479 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > @@ -465,7 +465,7 @@ ConvertMemoryPageAttributes ( > } > > // > - // Below logic is to check 2M/4K page to make sure we donot waist > memory. > + // Below logic is to check 2M/4K page to make sure we do not waste > memory. > // > while (Length != 0) { > PageEntry = GetPageTableEntry (BaseAddress, &PageAttribute); @@ - > 1065,7 +1065,7 @@ IsUefiPageNotPresent ( } > > /** > - Merge continous memory map entries whose type is > + Merge continuous memory map entries whose type is > EfiLoaderCode/Data, EfiBootServicesCode/Data, EfiConventionalMemory, > EfiUnusableMemory, EfiACPIReclaimMemory, because the memory > described by > these entries will be set as NOT present in SMM page table. > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c > index b1a492725a0c..661cc51f361a 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c > @@ -260,7 +260,7 @@ GetRegisterIndex ( > > @retval EFI_SUCCESS The register was read from Save State. > @retval EFI_NOT_FOUND The register is not defined for the Save > State > of Processor. > - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. > + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. > > **/ > EFI_STATUS > @@ -343,7 +343,7 @@ ReadSaveStateRegisterByIndex ( > > @retval EFI_SUCCESS The register was read from Save State. > @retval EFI_NOT_FOUND The register is not defined for the Save > State > of Processor. > - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. > + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. > > **/ > EFI_STATUS > @@ -455,7 +455,7 @@ ReadSaveStateRegister ( > > @retval EFI_SUCCESS The register was written to Save State. > @retval EFI_NOT_FOUND The register is not defined for the Save > State > of Processor. > - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct. > + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct. > > **/ > EFI_STATUS > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c > index ce1bf9fb541c..8c9de1fdae70 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c > @@ -58,7 +58,7 @@ SemaphoreHook ( > ); > > // > - // Use temp value to fix ICC complier warning > + // Use temp value to fix ICC compiler warning > // > TempValue = (UINTN)&mSmmRelocationOriginalAddress; > PatchInstructionX86 ( > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > index db06d22d51f4..8bfba55b5d08 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > @@ -16,7 +16,7 @@ > %include "Nasm.inc" > > ; > -; Variables referrenced by C code > +; Variables referenced by C code > ; > > %define MSR_IA32_S_CET 0x6A2 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm > b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm > index 8d81582bb1dd..9cf3a6dcf9d5 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm > @@ -72,7 +72,7 @@ BITS 64 > ASM_PFX(gPatchSmmInitStack): > and sp, 0xfff0 ; make sure RSP is 16-byte aligned > ; > - ; Accoring to X64 calling convention, XMM0~5 are volatile, we need to > save > + ; According to X64 calling convention, XMM0~5 are volatile, we need > + to save > ; them before calling C-function. > ; > sub rsp, 0x60 > -- > 2.21.0 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52960): https://edk2.groups.io/g/devel/message/52960 Mute This Topic: https://groups.io/mt/69396196/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
