Reviewed-by: jiewen....@intel.com
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Philippe
> Mathieu-Daudé
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <co...@gmx.fr>; Yao, Jiewen <jiewen....@intel.com>;
> Wang, Jian J <jian.j.w...@intel.com>; Zhang, Chao B
> <chao.b.zh...@intel.com>; Philippe Mathieu-Daude <phi...@redhat.com>
> Subject: [edk2-devel] [PATCH v2 65/78] SecurityPkg/Tcg: Fix various typos
>
> From: Antoine Coeur <co...@gmx.fr>
>
> Fix various typos in documentation, comments and debug strings.
>
> Cc: Jiewen Yao <jiewen....@intel.com>
> Cc: Jian J Wang <jian.j.w...@intel.com>
> Cc: Chao Zhang <chao.b.zh...@intel.com>
> Signed-off-by: Antoine Coeur <co...@gmx.fr>
> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <phi...@redhat.com>
> ---
> SecurityPkg/Tcg/TcgSmm/TcgSmm.inf | 2 +-
> SecurityPkg/Include/Library/TcgStorageCoreLib.h | 4 ++--
> SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h | 6 +++---
> SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c | 2 +-
> SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c | 2 +-
> SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 10 +++++-----
> SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 2 +-
> SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 8 ++++----
> .../Tcg/PhysicalPresencePei/PhysicalPresencePei.c | 2 +-
> SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c | 2 +-
> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++--
> SecurityPkg/Tcg/TcgPei/TcgPei.c | 8 ++++----
> SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni | 2 +-
> SecurityPkg/Tcg/TcgSmm/TcgSmm.uni | 2 +-
> 14 files changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf
> b/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf
> index 40827041cae4..29f9c15b0e02 100644
> --- a/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf
> +++ b/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf
> @@ -1,5 +1,5 @@
> ## @file
> -# Implements ACPI metholds for the TCG feature
> +# Implements ACPI methods for the TCG feature
> #
> # This driver implements TPM definition block in ACPI table and registers
> SMI
> # callback functions for physical presence and MemoryClear to handle the
> requests
> diff --git a/SecurityPkg/Include/Library/TcgStorageCoreLib.h
> b/SecurityPkg/Include/Library/TcgStorageCoreLib.h
> index c25a56a14ca2..01a44c667c80 100644
> --- a/SecurityPkg/Include/Library/TcgStorageCoreLib.h
> +++ b/SecurityPkg/Include/Library/TcgStorageCoreLib.h
> @@ -588,7 +588,7 @@ TcgAddEndTransaction(
> );
>
> /**
> - Initial the tcg parse stucture.
> + Initial the tcg parse structure.
>
> @param ParseStruct Input parse structure.
> @param Buffer Input buffer data.
> @@ -1218,7 +1218,7 @@ TcgParseSyncSession(
> @param HostSession Host session data.
> @param AceRow Ace row info.
> @param Authority1 Authority 1 info.
> - @param LogicalOperator Logiccal operator info.
> + @param LogicalOperator Logical operator info.
> @param Authority2 Authority 2 info.
>
> @retval Return the action result.
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h
> b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h
> index 0543a2ce493d..557c1f8d68da 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h
> @@ -247,7 +247,7 @@ GetDiskNameStringId(
>
> @param OpalDisk The Opal device.
>
> - @retval EFI_SUCCESS Initialize the device success.
> + @retval EFI_SUCCESS Initialize the device success.
> @retval EFI_DEVICE_ERROR Get info from device failed.
> @retval EFI_INVALID_PARAMETER Not get Msid info before get ownership
> info.
>
> @@ -348,7 +348,7 @@ HiiUninstall(
>
> @param Dev The Opal device.
>
> - @retval EFI_SUCCESS Initialize the device success.
> + @retval EFI_SUCCESS Initialize the device success.
> @retval EFI_DEVICE_ERROR Get info from device failed.
>
> **/
> @@ -362,7 +362,7 @@ OpalDiskInitialize (
>
> @param OpalDisk The Opal device.
>
> - @retval EFI_SUCCESS Get ownership success.
> + @retval EFI_SUCCESS Get ownership success.
> @retval EFI_ACCESS_DENIED Has send BlockSID command, can't change
> ownership.
> @retval EFI_INVALID_PARAMETER Not get Msid info before get ownership
> info.
>
> diff --git a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> index f9c57a13f2e4..660f79effd53 100644
> --- a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> +++ b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> @@ -837,7 +837,7 @@ TcgAddEndTransaction(
> }
>
> /**
> - Initial the tcg parse stucture.
> + Initial the tcg parse structure.
>
> @param ParseStruct Input parse structure.
> @param Buffer Input buffer data.
> diff --git a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
> b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
> index b6d5cf9890a0..ff331bfc8ad9 100644
> --- a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
> +++ b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
> @@ -640,7 +640,7 @@ TcgSetAuthorityEnabled(
> @param HostSession Host session data.
> @param AceRow Ace row info.
> @param Authority1 Authority 1 info.
> - @param LogicalOperator Logiccal operator info.
> + @param LogicalOperator Logical operator info.
> @param Authority2 Authority 2 info.
>
> @retval Return the action result.
> diff --git a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> index 97e819edf4d5..f2529fb9888b 100644
> --- a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> +++ b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> @@ -61,7 +61,7 @@ OnReadyToBoot (
> Typically, there are 2 mechanism for resetting eDrive. They are:
> 1. TPer Reset through IEEE 1667 protocol.
> 2. TPer Reset through native TCG protocol.
> - This routine will detect what protocol the attached eDrive comform to, TCG
> or
> + This routine will detect what protocol the attached eDrive conform to, TCG
> or
> IEEE 1667 protocol. Then send out TPer Reset command separately.
>
> @param[in] Ssp The pointer to
> EFI_STORAGE_SECURITY_COMMAND_PROTOCOL instance.
> @@ -109,7 +109,7 @@ InitiateTPerReset (
> MediaId,
> 100000000, // Timeout 10-sec
> 0, // SecurityProtocol
> - 0, //
> SecurityProtocolSpecifcData
> + 0, //
> SecurityProtocolSpecificData
> Len, // PayloadBufferSize,
> Buffer, // PayloadBuffer
> &XferSize
> @@ -145,7 +145,7 @@ InitiateTPerReset (
> MediaId,
> 100000000, // Timeout 10-sec
> 0, // SecurityProtocol
> - 0, //
> SecurityProtocolSpecifcData
> + 0, //
> SecurityProtocolSpecificData
> Len, // PayloadBufferSize,
> Buffer, // PayloadBuffer
> &XferSize
> @@ -197,7 +197,7 @@ InitiateTPerReset (
> MediaId,
> 100000000, // Timeout 10-sec
> SECURITY_PROTOCOL_TCG, // SecurityProtocol
> - 0x0400, //
> SecurityProtocolSpecifcData
> + 0x0400, //
> SecurityProtocolSpecificData
> 512, // PayloadBufferSize,
> Buffer // PayloadBuffer
> );
> @@ -341,7 +341,7 @@ MorDriverEntryPoint (
> //
> // Create a Ready To Boot Event and Clear the MorControl bit in the call
> back
> function.
> //
> - DEBUG ((DEBUG_INFO, "TcgMor: Create ReadyToBoot Event for MorControl
> Bit cleaning!\n"));
> + DEBUG ((EFI_D_INFO, "TcgMor: Create ReadyToBoot Event for MorControl
> Bit cleaning!\n"));
> Status = EfiCreateEventReadyToBootEx (
> TPL_CALLBACK,
> OnReadyToBoot,
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> index 6bec54b93217..b5b6aec98caf 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> @@ -2583,7 +2583,7 @@ OpalDriverGetDriverDeviceName(
> @param ImageHandle Image Handle this driver.
> @param SystemTable Pointer to SystemTable.
>
> - @retval EFI_SUCCESS This function always complete successfully.
> + @retval EFI_SUCCESS This function always complete successfully.
> **/
> EFI_STATUS
> EFIAPI
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
> b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
> index ef117d3d031e..211e75537a07 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
> @@ -1110,7 +1110,7 @@ OpalHiiGetBrowserData (
> Set a string Value in a form.
>
> @param DestStringId The stringid which need to update.
> - @param SrcAsciiStr The string nned to update.
> + @param SrcAsciiStr The string need to update.
>
> @retval EFI_SUCCESS Do the required action success.
> @retval Others Other error occur.
> @@ -1164,7 +1164,7 @@ HiiSetFormString(
>
> @param Dev The Opal device.
>
> - @retval EFI_SUCCESS Initialize the device success.
> + @retval EFI_SUCCESS Initialize the device success.
> @retval EFI_DEVICE_ERROR Get info from device failed.
>
> **/
> @@ -1220,7 +1220,7 @@ OpalDiskInitialize (
>
> @param OpalDisk The Opal device.
>
> - @retval EFI_SUCCESS Get ownership success.
> + @retval EFI_SUCCESS Get ownership success.
> @retval EFI_ACCESS_DENIED Has send BlockSID command, can't change
> ownership.
> @retval EFI_INVALID_PARAMETER Not get Msid info before get ownership
> info.
>
> @@ -1254,7 +1254,7 @@ OpalDiskUpdateOwnerShip (
>
> @param OpalDisk The Opal device.
>
> - @retval EFI_SUCCESS Initialize the device success.
> + @retval EFI_SUCCESS Initialize the device success.
> @retval EFI_DEVICE_ERROR Get info from device failed.
> @retval EFI_INVALID_PARAMETER Not get Msid info before get ownership
> info.
> @retval EFI_ACCESS_DENIED Has send BlockSID command, can't change
> ownership.
> diff --git a/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.c
> b/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.c
> index 83c3ad50d1a2..89c1be0417ed 100644
> --- a/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.c
> +++ b/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.c
> @@ -31,7 +31,7 @@ LockTpmPhysicalPresence (
> );
>
> //
> -// Global defintions for lock physical presence PPI and its descriptor.
> +// Global definitions for lock physical presence PPI and its descriptor.
> //
> PEI_LOCK_PHYSICAL_PRESENCE_PPI mLockPhysicalPresencePpi = {
> LockTpmPhysicalPresence
> diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c
> b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c
> index e0d0a207e1bf..0f9bad724ebf 100644
> --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c
> +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c
> @@ -141,7 +141,7 @@ Tcg2ConfigPeimEntryPoint (
> ASSERT_EFI_ERROR (Status);
>
> //
> - // Even if no TPM is selected or detected, we still need intall
> TpmInitializationDonePpi.
> + // Even if no TPM is selected or detected, we still need install
> TpmInitializationDonePpi.
> // Because TcgPei or Tcg2Pei will not run, but we still need a way to
> notify
> other driver.
> // Other driver can know TPM initialization state by TpmInitializedPpi.
> //
> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> index 1565d4e40219..e8a2b3f2b2ad 100644
> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> @@ -933,7 +933,7 @@ PeimEntryMA (
> }
>
> //
> - // Only intall TpmInitializedPpi on success
> + // Only install TpmInitializedPpi on success
> //
> Status = PeiServicesInstallPpi (&mTpmInitializedPpiList);
> ASSERT_EFI_ERROR (Status);
> @@ -954,7 +954,7 @@ Done:
> );
> }
> //
> - // Always intall TpmInitializationDonePpi no matter success or fail.
> + // Always install TpmInitializationDonePpi no matter success or fail.
> // Other driver can know TPM initialization state by TpmInitializedPpi.
> //
> Status2 = PeiServicesInstallPpi (&mTpmInitializationDonePpiList);
> diff --git a/SecurityPkg/Tcg/TcgPei/TcgPei.c b/SecurityPkg/Tcg/TcgPei/TcgPei.c
> index 284fc394f063..a9a808c9ecf3 100644
> --- a/SecurityPkg/Tcg/TcgPei/TcgPei.c
> +++ b/SecurityPkg/Tcg/TcgPei/TcgPei.c
> @@ -146,7 +146,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mNotifyList[] = {
> };
>
> /**
> - Record all measured Firmware Voluem Information into a Guid Hob
> + Record all measured Firmware Volume Information into a Guid Hob
> Guid Hob payload layout is
>
> UINT32 *************************** FIRMWARE_BLOB number
> @@ -501,7 +501,7 @@ MeasureMainBios (
> }
>
> /**
> - Measure and record the Firmware Voluem Information once FvInfoPPI install.
> + Measure and record the Firmware Volume Information once FvInfoPPI install.
>
> @param[in] PeiServices An indirect pointer to the EFI_PEI_SERVICES
> table
> published by the PEI Foundation.
> @param[in] NotifyDescriptor Address of the notification descriptor data
> structure.
> @@ -824,7 +824,7 @@ PeimEntryMA (
> }
>
> //
> - // Only intall TpmInitializedPpi on success
> + // Only install TpmInitializedPpi on success
> //
> Status = PeiServicesInstallPpi (&mTpmInitializedPpiList);
> ASSERT_EFI_ERROR (Status);
> @@ -845,7 +845,7 @@ Done:
> );
> }
> //
> - // Always intall TpmInitializationDonePpi no matter success or fail.
> + // Always install TpmInitializationDonePpi no matter success or fail.
> // Other driver can know TPM initialization state by TpmInitializedPpi.
> //
> Status2 = PeiServicesInstallPpi (&mTpmInitializationDonePpiList);
> diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni
> b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni
> index dbb4924c0d99..d6e047d74577 100644
> --- a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni
> +++ b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni
> @@ -1,5 +1,5 @@
> // /** @file
> -// Provides ACPI metholds for TPM 2.0 support
> +// Provides ACPI methods for TPM 2.0 support
> //
> // This driver implements TPM 2.0 definition block in ACPI table and
> // registers SMI callback functions for TCG2 physical presence and
> diff --git a/SecurityPkg/Tcg/TcgSmm/TcgSmm.uni
> b/SecurityPkg/Tcg/TcgSmm/TcgSmm.uni
> index 807163367023..a3abb3addf0c 100644
> --- a/SecurityPkg/Tcg/TcgSmm/TcgSmm.uni
> +++ b/SecurityPkg/Tcg/TcgSmm/TcgSmm.uni
> @@ -1,5 +1,5 @@
> // /** @file
> -// Implements ACPI metholds for the TCG feature
> +// Implements ACPI methods for the TCG feature
> //
> // This driver implements TPM definition block in ACPI table and registers
> SMI
> // callback functions for physical presence and MemoryClear to handle the
> requests
> --
> 2.21.0
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52806): https://edk2.groups.io/g/devel/message/52806
Mute This Topic: https://groups.io/mt/69395964/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
