Reamer commented on a change in pull request #4109:
URL: https://github.com/apache/zeppelin/pull/4109#discussion_r627381250
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/search/LuceneSearch.java
##########
@@ -371,6 +372,7 @@ private void deleteDoc(String noteId, Paragraph p) {
* @see org.apache.zeppelin.search.Search#close()
*/
@Override
+ @PreDestroy
public void close() {
try {
indexWriter.close();
Review comment:
I think it would be better if Notebook and SearchService worked
independently.
I have moved `@PreDestroy` to `SearchService` because this service is
started by Jetty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
