[GitHub] [zeppelin] cuspymd commented on a change in pull request #4109: [ZEPPELIN-5357] Remove lucene writer lock during shutdown

[GitBox]

cuspymd commented on a change in pull request #4109:
URL: https://github.com/apache/zeppelin/pull/4109#discussion_r626600936



##########
File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/search/LuceneSearch.java
##########
@@ -371,6 +372,7 @@ private void deleteDoc(String noteId, Paragraph p) {
    * @see org.apache.zeppelin.search.Search#close()
    */
   @Override
+  @PreDestroy
   public void close() {
     try {
       indexWriter.close();

Review comment:
       This is an overridden method, is it okay if the parent class's `close()` 
is not called? One method of the parent classes, 
`NoteEventAsyncListener::close()` has an arbitrary implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org