[GitHub] [zeppelin] Reamer commented on a change in pull request #4109: [ZEPPELIN-5357] Remove lucene writer lock during shutdown

[GitBox]

Reamer commented on a change in pull request #4109:
URL: https://github.com/apache/zeppelin/pull/4109#discussion_r628272344



##########
File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/search/LuceneSearch.java
##########
@@ -371,6 +372,7 @@ private void deleteDoc(String noteId, Paragraph p) {
    * @see org.apache.zeppelin.search.Search#close()
    */
   @Override
+  @PreDestroy
   public void close() {
     try {
       indexWriter.close();

Review comment:
       The `@PreDestroy` annotation works in the child class if you do not 
overwrite the method with the `@PreDestroy` annotation in the child class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org