[GitHub] [zeppelin] Reamer commented on a change in pull request #4109: [ZEPPELIN-5357] Remove lucene writer lock during shutdown

[GitBox]

Reamer commented on a change in pull request #4109:
URL: https://github.com/apache/zeppelin/pull/4109#discussion_r626684080



##########
File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/search/LuceneSearch.java
##########
@@ -371,6 +372,7 @@ private void deleteDoc(String noteId, Paragraph p) {
    * @see org.apache.zeppelin.search.Search#close()
    */
   @Override
+  @PreDestroy
   public void close() {
     try {
       indexWriter.close();

Review comment:
       You are right, we should call `super.close()` to close the LuceneSearch 
thread.
   What is the right place for the `@PreDestroy` annotation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org