Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31829055
--- Diff: lib/atscppapi/examples/helloworld/HelloWorldPlugin.cc ---
@@ -20,16 +20,23 @@
#include <iostream>
#include <atscppapi/GlobalPlugin.h>
#include <atscppapi/PluginInit.h>
-
+#include <../../../../proxy/api/ts/ts.h>
--- End diff --
I think the plugin shouldn't include ts.h at all - it should call a wrapper
function provided by the CPP API core, if for no other reason than avoiding
this issue. Then we can at least isolate the ugliness in one spot and in the
core.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
