Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/214#discussion_r32853430
--- Diff: lib/atscppapi/examples/async_http_fetch/AsyncHttpFetch.cc ---
@@ -214,6 +214,7 @@ void
TSPluginInit(int argc ATSCPPAPI_UNUSED, const char *argv[]
ATSCPPAPI_UNUSED)
{
TS_DEBUG(TAG, "Loaded async_http_fetch_example plugin");
+ atscppapi::TSRegisterPlugin( std::string("CPP_Example_AsyncHttpFetch"),
std::string("apache"), std::string("i...@example.com"));
--- End diff --
#. There's a `using namespace atscppapi` at the head of the file so you
don't need to qualify this call.
#. Literal strings will auto promote to `std::string` arguments so no need
to do that explicitly.
#. Make the email address "us...@trafficserver.apache.org"
#. If you can, clang format the files as you edit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
