Github user bgaff commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/214#discussion_r31977617
  
    --- Diff: lib/atscppapi/src/include/atscppapi/Transaction.h ---
    @@ -30,7 +30,7 @@
     #include "atscppapi/shared_ptr.h"
     #include "atscppapi/ClientRequest.h"
     #include "atscppapi/Response.h"
    -
    +#include <../ts/apidefs.h>
    --- End diff --
    
    We can't do this. The pattern we've always followed with the ats c++ api is 
that it shouldn't require including any C header files. We've typically just 
duplicated enums so TSOverridableConfigKey should be an enum in Transaction.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to