Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31773507
--- Diff: lib/atscppapi/examples/globalhook/GlobalHookPlugin.cc ---
@@ -19,24 +19,30 @@
#include <iostream>
#include <atscppapi/GlobalPlugin.h>
#include <atscppapi/PluginInit.h>
-
+#include<../ts/Diags.h>
using namespace atscppapi;
class GlobalHookPlugin : public GlobalPlugin
{
public:
GlobalHookPlugin() { registerHook(HOOK_READ_REQUEST_HEADERS_PRE_REMAP); }
-
+
virtual void
handleReadRequestHeadersPreRemap(Transaction &transaction)
- {
- std::cout << "Hello from handleReadRequesHeadersPreRemap!" <<
std::endl;
- transaction.resume();
+ {
+ std::cout << "Hello from handleReadRequesHeadersPreRemap!" <<
std::endl;
+ transaction.resume();
}
};
void
TSPluginInit(int argc ATSCPPAPI_UNUSED, const char *argv[]
ATSCPPAPI_UNUSED)
{
+ TSPluginRegistrationInfo info;
--- End diff --
You should have a wrapper for PluginInit. It might also be reasonable to
split off the fixes to the example plugins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
