On 16.02.2015 20:22, Bert Huijben wrote:


-----Original Message----- From: Stefan Kueng
[mailto:tortoise...@gmail.com] Sent: maandag 16 februari 2015
20:01 To: Subversion Development Subject: pin externals when
creating a copy from specific revision

Hi,

I'm still doing some testing with the new --pin-externals feature,
and I found a situation which I'm not sure should be handled that
way:

imagine the repo is at r100. Now if one does a svn copy
http://server/trunk http://server/branches/b1 -r50 --pin-externals

then all externals get pinned at r100. But shouldn't in-repo
externals get pinned to r50 instead? At least in this kind of copy,
I think those externals should get pinned to r50?

I can see your reasoning but this is the same behavior as an svn
checkout of the same revision, so changing it will introduce a
new/different issue... And this is the same thing as we would do as
to externals pointing to other repositories.

I'm curious: what kind of other issues would this cause?
Or is there an issue of not recognizing externals of the same repository in all situations?

My usual use case for creating a copy not from HEAD but an earlier revision is when I forgot to create a tag, and there have already been other commits done after making the release. So in that situation, it would be wrong to pin the externals (those pointing to the same repository) to HEAD but those should be pinned to the revision I'm creating the tag from. Checking out that tag then would work as I expect - if the externals were pinned to HEAD, the project might not compile.

Stefan

Reply via email to