pjfawcett commented on a change in pull request #278:
URL: https://github.com/apache/qpid-proton/pull/278#discussion_r564449245
##########
File path: cpp/src/connection.cpp
##########
@@ -192,6 +193,13 @@ std::vector<symbol> connection::desired_capabilities()
const {
return get_multiple<std::vector<symbol> >(caps);
}
+std::map<symbol, value> connection::properties() const {
+ map<symbol, value> props(pn_connection_remote_properties(pn_object()));
+ std::map<symbol, value> props_ret;
+ get(props, props_ret);
+ return props_ret;
Review comment:
Thanks for your elucidation. I was mis-remembering my earlier attempts
but your suggestion helped me track down why my earlier code had been failing
the unit tests (memory management in the non-NULL case).
I have ended up with a slight variation on your suggestion due to a
preference for single return points, but I think it is as efficient - and an
improvement on my first submission.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
