jiridanek commented on a change in pull request #278:
URL: https://github.com/apache/qpid-proton/pull/278#discussion_r562413322
##########
File path: cpp/src/container_test.cpp
##########
@@ -179,6 +181,22 @@ int test_container_capabilities() {
ASSERT_EQUAL(th.peer_offered_capabilities[0], proton::symbol("offered"));
ASSERT_EQUAL(th.peer_desired_capabilities.size(), 1u);
ASSERT_EQUAL(th.peer_desired_capabilities[0], proton::symbol("desired"));
+ ASSERT_EQUAL(th.peer_properties.size(), 0u);
+ return 0;
+}
+
+int test_container_properties() {
+ proton::connection_options opts;
+ std::map<proton::symbol, proton::value> props = {
+ {"qpid.client_process", "test_process"},
+ {"qpid.client_pid", 123}
+ };
Review comment:
Do we? @ssorj afaik we don't have to support C++03 any more on what's to
become Proton 0.34, or am I wrong?
##########
File path: cpp/src/container_test.cpp
##########
@@ -179,6 +181,22 @@ int test_container_capabilities() {
ASSERT_EQUAL(th.peer_offered_capabilities[0], proton::symbol("offered"));
ASSERT_EQUAL(th.peer_desired_capabilities.size(), 1u);
ASSERT_EQUAL(th.peer_desired_capabilities[0], proton::symbol("desired"));
+ ASSERT_EQUAL(th.peer_properties.size(), 0u);
+ return 0;
+}
+
+int test_container_properties() {
+ proton::connection_options opts;
+ std::map<proton::symbol, proton::value> props = {
+ {"qpid.client_process", "test_process"},
+ {"qpid.client_pid", 123}
+ };
Review comment:
Do we? @ssorj afaik we don't have to support C++03 any more in what's to
become Proton 0.34, or am I wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
