astitcher commented on a change in pull request #278:
URL: https://github.com/apache/qpid-proton/pull/278#discussion_r564574586
##########
File path: cpp/src/connection.cpp
##########
@@ -192,6 +193,15 @@ std::vector<symbol> connection::desired_capabilities()
const {
return get_multiple<std::vector<symbol> >(caps);
}
+std::map<symbol, value> connection::properties() const {
+ std::map<symbol, value> props_ret;
+ value props(pn_connection_remote_properties(pn_object()));
+ if (!props.empty()) {
+ get(props, props_ret);
+ }
+ return props_ret;
+}
+
Review comment:
I agree this is as efficient as my version - My preference is for
multiple returns over (IMO) meaningless local variables. But just my preference
- this is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
