astitcher commented on a change in pull request #278:
URL: https://github.com/apache/qpid-proton/pull/278#discussion_r562648794
##########
File path: cpp/src/container_test.cpp
##########
@@ -179,6 +181,22 @@ int test_container_capabilities() {
ASSERT_EQUAL(th.peer_offered_capabilities[0], proton::symbol("offered"));
ASSERT_EQUAL(th.peer_desired_capabilities.size(), 1u);
ASSERT_EQUAL(th.peer_desired_capabilities[0], proton::symbol("desired"));
+ ASSERT_EQUAL(th.peer_properties.size(), 0u);
+ return 0;
+}
+
+int test_container_properties() {
+ proton::connection_options opts;
+ std::map<proton::symbol, proton::value> props = {
+ {"qpid.client_process", "test_process"},
+ {"qpid.client_pid", 123}
+ };
Review comment:
At this point we still support C++03. I think 0.34 will be the last
release to do this (and also python 2.7) We should announce a one release
deprecation on the mailing list, and have a clean break from Proton 0.34 to
0.35.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
