+1 It would also be great to also add this in contributor guidelines.
On 2023/02/12 05:39:25 Dinesh Chitlangia wrote: > +1. > > 15 days can be too long and and especially the new contributors would feel > more stalled. > As long as the reviewer's comments are addressed and there is at least 1 > binding +1, it should be totally fine to go ahead. > > Thanks, > Dinesh > > On Thu, Feb 2, 2023 at 11:30 AM Neil Joshi <neil...@gmail.com> wrote: > > > +1 > > > > On Wed, Feb 1, 2023 at 7:36 PM Hui Fei <feihui.u...@gmail.com> wrote: > > > > > +1 > > > > > > Uma Maheswara Rao Gangumalla <umamah...@apache.org> 于2023年2月1日周三 > > 06:51写道： > > > > > > > Dear Ozone Devs, > > > > > > > > This has been brought up by Ritesh in community sync. I thought we > > could > > > > discuss this more broadly and set up some path forwarding options. > > > > > > > > With my past experience, when a reviewer does not respond for a long > > time > > > > and if another reviewer helped to review, we will just give a few days' > > > > wait for the old reviewer to confirm his comments. If no further > > > responses > > > > from the old reviewer, we used to move ahead. > > > > > > > > I think we can follow the similar approach: > > > > > > > > When the reviewer does not respond for a long time (say 15days? ): > > > > The Author can freely ping other reviewers to help if no one else > > > > reviewed it yet. > > > > If the other reviewer is a committer and got +1 from him, then we > > can > > > > give a 3-7days time window for the old reviewer to check as a final > > > > friendly reminder. If still no responses, then we can just move ahead > > for > > > > commit based new committer reviewer's +1. > > > > > > > > Thoughts? > > > > > > > > Regards, > > > > Uma > > > > > > > > > > > > > -- > > NJ > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
