As a general rule of thumb, the open questions should be addressed in a follow-up PR, opened by the patch author or on a suggestion from the committer giving the binding +1. This allows the reviewer, let's say who is on vacation to come back to it and still get their concerns addressed.
Best, Sid On Wed, Feb 1, 2023 at 11:10 AM Arpit Agarwal <aagar...@cloudera.com.invalid> wrote: > 15 days is too long. We shouldn't hold up progress for weeks waiting for a > reviewer to come back. > > If the original reviewer’s comments were addressed, I see no harm in > moving forward with a binding +1 from another reviewer. The exception is a > binding veto. > > > > On Jan 31, 2023, at 2:50 PM, Uma Maheswara Rao Gangumalla < > umamah...@apache.org> wrote: > > > > Dear Ozone Devs, > > > > This has been brought up by Ritesh in community sync. I thought we could > > discuss this more broadly and set up some path forwarding options. > > > > With my past experience, when a reviewer does not respond for a long time > > and if another reviewer helped to review, we will just give a few days' > > wait for the old reviewer to confirm his comments. If no further > responses > > from the old reviewer, we used to move ahead. > > > > I think we can follow the similar approach: > > > > When the reviewer does not respond for a long time (say 15days? ): > > The Author can freely ping other reviewers to help if no one else > > reviewed it yet. > > If the other reviewer is a committer and got +1 from him, then we can > > give a 3-7days time window for the old reviewer to check as a final > > friendly reminder. If still no responses, then we can just move ahead for > > commit based new committer reviewer's +1. > > > > Thoughts? > > > > Regards, > > Uma > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org > For additional commands, e-mail: dev-h...@ozone.apache.org > >
