On Wed, Jul 13, 2016 at 03:53:00PM +0300, Ilya Maximets wrote: > Hi, Daniele. > Thanks for review. > > On 13.07.2016 04:15, Daniele Di Proietto wrote: > > Thanks for the patch. > > > > This is not a complete review, but I have some preliminary comments. > > > > If I understand correctly 'port_mutex' is converted to rwlock because > > we want the pmd threads in dpif_netdev_xps_get_tx_qid() to be able to > > grab it concurrently. I think that we can add a pointer from 'struct > > tx_port' to 'struct dp_netdev_port' and access that without locking. > > As long as a port is in a pmd thread tx_port cache it cannot be > > deleted from the datapath. This way we can avoid the rwlock. > > Yes. Thank you for suggestion. This greatly simplifies this patch set. > It become almost 2 times smaller.
It looks like v4 doesn't need the fat-rwlock change, then? I had been planning to review it but I'll skip it in that case. Please let me know if you still want me to review it. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
