----- Original Message -----
> From: "Ben Pfaff" <b...@ovn.org>
> To: "Lance Richardson" <lrich...@redhat.com>
> Cc: dev@openvswitch.org
> Sent: Friday, June 10, 2016 11:16:08 AM
> Subject: Re: [ovs-dev] [PATCH] tests: fix issue in use of
> OVS_APP_EXIT_AND_WAIT
>
> On Fri, Jun 03, 2016 at 06:09:26PM -0400, Lance Richardson wrote:
> > Commit f9b11f2a09b4 introduced a loop to wait for process exit
> > in OVS_APP_EXIT_AND_WAIT after the "exit" command has been sent.
> > Unfortunately, this does not work for cases where a unixctl socket
> > has to be used to send the "exit" command because the process
> > ID cannot be determined from the socket path.
> >
> > OVS_APP_EXIT_AND_WAIT_BY_TARGET has since been introduced to enable
> > graceful termination of daemons via unixctl sockets.
> >
> > This set of changes addresses the problem described above by
> > making OVS_APP_EXIT_AND_WAIT_BY_TARGET take the unixctl socket
> > path and corresponding process ID as separate parameters. In order
> > to better detect issues in this logic in the future, checks have
> > been added to verify that the pidfile exists before using its
> > contents.
> >
> > Tested on a Linux system.
> >
> > Fixes: f9b11f2a09b4 ("tests: Make OVS_APP_EXIT_AND_WAIT() wait for process
> > termination")
> > Signed-off-by: Lance Richardson <lrich...@redhat.com>
>
> I get tons of failures similar to the following with this applied:
>
After updating I see the same errors, looks like a collision with:
868dae908db0 ovs-vsctl.at: Use OVS_VSCTL_CLEANUP.
I'll fix and post a v2.
Thanks,
Lance
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
