Hi Ben, Regarding https://patchwork.ozlabs.org/patch/630046/ :
I see that this patch is marked "changes requested" in patchwork. I believe this is due to Alin's request (below). I'm having trouble understanding how the offending line is finding its way into ovsdb-server-log; I've attempted to recreate but after resurrecting a Windows box and working out how to build ovs on it, I've found that (sadly) ovs builds but has unresolved run-time linkage issues on win7. Do you have any suggestions for moving forward? Thanks, Lance ----- Original Message ----- > From: "Lance Richardson" <lrich...@redhat.com> > To: "Alin Serdean" <aserd...@cloudbasesolutions.com> > Cc: dev@openvswitch.org, "Paul Boca" <pb...@cloudbasesolutions.com> > Sent: Tuesday, June 7, 2016 10:40:46 AM > Subject: Re: [ovs-dev] [PATCH] tests: fix issue in use of > OVS_APP_EXIT_AND_WAIT > > ----- Original Message ----- > > From: "Alin Serdean" <aserd...@cloudbasesolutions.com> > > To: "Lance Richardson" <lrich...@redhat.com>, dev@openvswitch.org > > Cc: "Paul Boca" <pb...@cloudbasesolutions.com> > > Sent: Monday, June 6, 2016 8:52:37 PM > > Subject: RE: [ovs-dev] [PATCH] tests: fix issue in use of > > OVS_APP_EXIT_AND_WAIT > > > > Hi Lance, > > > > Thanks a lot for the patch just one small nit on the windows side, please > > see > > inlined comment. > > > > Thanks, > > Alin. > > > > [snip] > > > [Alin Gabriel Serdean: ] We need something like the following in some > > situations: > > AT_CHECK([ovs-appctl --target=$1 exit], [0], [ignore], [ignore]) > > The reason behind it is that we do not want to append the commands > > generated > > by ovs-appctl to be logged (like in the case of a kill command). > > Allowing more arguments to the current macro or adding another one which > > disables logging might do the trick. > > I.E. difference between Linux / Windows on test 1747 (testing monitor > > insert > > into empty table ): > > [snip] > > > 1747. ovsdb-monitor.at:47: FAILED (ovsdb-monitor.at:47) > > > OVS_WAIT_WHILE([kill -0 $TMPPID 2>/dev/null])]) > > > Hi Alin, > > I take it you're referring to the OVS_WAIT_WHILE(...) output at the end. > Since > it's prefixed with '>' and appears after the "FAILED" message, I'm guessing > it's from "at_fn_log_failure ovsdb-server-log" at the end of the compiled > test > case, which comes from "AT_CAPTURE_FILE([ovsdb-server-log])" in the test case > source. > But I'm at a loss for an explanation as to why this line might be in > ovsdb-server-log > in the first place. > > Since "OVS_WAIT_WHILE(...)" is not within an AT_CHECK() macro, the > stdin/stderr "ignore" > stuff doesn't seem to apply. > > Hmmm.... > > Lance > > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
